Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added asterisks to required fields on checkout #202

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

jamesros161
Copy link
Contributor

The 3rd party package FloatLabels was causing an issue where the asterisks were not being carried over when converting the labels into the FloatLabels. This will resolve #37 by re-adding the asterisks.

@jamesros161 jamesros161 requested review from bwmarkle and rramo012 and removed request for bwmarkle May 29, 2020 20:55
Copy link
Member

@rramo012 rramo012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@jamesros161 jamesros161 merged commit 1b762cf into master Jun 2, 2020
@jamesros161 jamesros161 deleted the issue-37 branch June 10, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required fields in checkout missing asterisk
2 participants