Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce overhead to convert non-connectable BluetoothServiceInfoBleak to connectable #135

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 1, 2025

No description provided.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.03%. Comparing base (a1945ce) to head (7417675).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/habluetooth/manager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   82.66%   84.03%   +1.36%     
==========================================
  Files          12       12              
  Lines        1200     1215      +15     
  Branches      139      139              
==========================================
+ Hits          992     1021      +29     
+ Misses        158      145      -13     
+ Partials       50       49       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 1, 2025

CodSpeed Performance Report

Merging #135 will not alter performance

Comparing as_connectable (7417675) with main (a1945ce)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco merged commit 37fc839 into main Feb 1, 2025
26 checks passed
@bdraco bdraco deleted the as_connectable branch February 1, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant