Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle devices listed before adapter in dbus managed objects #174

Conversation

JOSEPHGILBY
Copy link
Contributor

@JOSEPHGILBY JOSEPHGILBY commented Oct 31, 2024

Attempt 2 since GH crashed on accepting commits.

Handles the case where if a devices are listed before an adapter when getting the managed objects from dbus, the devices won't be returned from _adapters_from_managed_objects.

fixes #172

@bdraco bdraco changed the title Fix #172 and handle devices listed before adapter in dbus managed objects fix: handle devices listed before adapter in dbus managed objects Oct 31, 2024
@bdraco
Copy link
Member

bdraco commented Oct 31, 2024

Too tired to keep looking. Will look tomorrow

@bdraco bdraco merged commit 69b0d16 into Bluetooth-Devices:main Oct 31, 2024
18 of 19 checks passed
@bdraco
Copy link
Member

bdraco commented Oct 31, 2024

Thanks @JOSEPHGILBY

@bdraco
Copy link
Member

bdraco commented Oct 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_adapters_from_managed_objects in dbus.py doesn't ensure managedobject entry implements interface.
2 participants