Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition variable #92

Merged
merged 46 commits into from
May 6, 2021
Merged

Condition variable #92

merged 46 commits into from
May 6, 2021

Conversation

BichengYing
Copy link
Collaborator

No description provided.

BichengYing and others added 30 commits February 7, 2021 21:06
@BichengYing
Fixed the self_weight under emtpy receiving case
61b472c
Enable empty send neighbors and fix HalfTensor for recv_size==0
7e8ea66
@BichengYing
Fixed the self_weight under emtpy receiving case
1d43096
Enable empty send neighbors and fix HalfTensor for recv_size==0
c082ce9
Merge branch 'improve_neighbor_allreduce' of https://github.com/ybc19…
50933fb 
…91/bluefog into improve_neighbor_allreduce
Rename neighbor_weights to src_weights, and send_neighbors to dst_wei…
a3365b3 
…ghts for neighbor_allreduce
A script to test existing examples
cf17875
Accept dst_weights as Dict, and reorganize DoNeighborAllreduce
923df09
Reorganize CheckNeighborSendRecvPattern
42d0af7
Fix timeline_ptr for NCCL
3184e17
Fix timeline_ptr for NCCL
c85cbd5
Merge branch 'improve_neighbor_allreduce' of https://github.com/ybc19…
8d9fe31 
…91/bluefog into improve_neighbor_allreduce
Put dst_weights information into TensorTableEntry
7d60585
First Version of neighbor_allreduce dst_weight, existing problem: Fus…
79c57b3 
…ion Not Implemented, CUDA data_weight problem
Add some delay after data_weight as a temporary solution
29a239c
CPU Fusion for dst_weighted added
97517b3
Merge branch 'master' into improve_neighbor_allreduce
364f5fd
Add ReadyEvent for dst_weight for single entry neighbor_allreduce
cc9faf4
Remove const identifier for tensor dtype as it is meaningless
7f47ce4
Add cuda source for scalebuffer
d84138b
Scale buffer to modify itself
06c375d
Add .o file to .gitignore
e4db92f
dst_weight using CUDA for fused entry & compile flow in Python setup.py
ec2a3fc
make clean *.o files generated by nvcc
adaa191
Add fix for NCCL single entry
46e6431
Make setup.py more robust
ae57e75
Add timeout and cuda check
62dc99d
Move test example
a836b02
Fix NCCL side dst_weight fusion bug
e02a3d0
Add agg to make matplotlib more stable
8e42ca2
Hanbin Hu and others added 16 commits March 21, 2021 01:25
Address comments for setup.py
e5f8722
Simpler logic for dst_weighting_enabled and weighted_average_computation
9f2f55d
Better consideration for weight buffer size
d7a9310
Merge branch 'master' into improve_neighbor_allreduce
2fe9621
Make src_weights as std::map, and simplify logic for PerformNeighborA…
562b231 
…llreduceCallback
Add TODO #80 and #81, and simplify the logic for dst_weight
6764efa
Wrap CheckNeighborSendRecvPattern again
1e8db23
Add two more TODOs
3d90087
Address review comments
96887b5
@BichengYing
Add condition variable to control the loop
f3f3b59
@BichengYing
Minor update on topology_setting in global_state
8cb9afd
@BichengYing
Add missing <condition_variable> header
c92a710
@BichengYing
Change cv.wait to cv.wait_for 10 seconds
dca33a8
@BichengYing
Address comment and remove adjusting resetVersionWinMem in ibfrun
fd82d65
@BichengYing
Merge branch 'master' into condition_variable
61589ed
@BichengYing
Add lock to protect loop_cv notify_one
6bf0d0e
@BichengYing BichengYing requested a review from hanbinhu May 6, 2021 04:51
@BichengYing BichengYing merged commit c576f12 into master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanbinhu hanbinhu Awaiting requested review from hanbinhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BichengYing