This repository was archived by the owner on Jan 29, 2024. It is now read-only.
[BBS-145] Rewriting the mining schema class #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stannislav
requested review from
jankrepl,
EmilieDel and
pafonta
and removed request for
jankrepl
|
I think that's the first time the test fail on packaging tests. I hope it's a Travis glitch. |
jankrepl
approved these changes
Nov 2, 2020
Comment on lines
-1118
to
+1107
| "display_name": "BBS-BBG", | ||
| "display_name": "Python 3", | ||
| "language": "python", | ||
| "name": "devel" | ||
| "name": "python3" |
There was a problem hiding this comment.
Personally I do not care, but did we not have a policy of git checkout -p of these irrelevant changes?
There was a problem hiding this comment.
Ah, I must have missed that policy discussion. How should we do it?
And yes, I'm also annoyed by the diffs of the notebook.
There was a problem hiding this comment.
I vaguely remember that @FrancescoCasalegno pointed this out for some of our previous PRs.
There seems to be some scripts that take out the output + metadata automatically, for example
jupyter/nbconvert#805
| @@ -1129,7 +1116,7 @@ | |||
| "name": "python", | |||
| "nbconvert_exporter": "python", | |||
| "pygments_lexer": "ipython3", | |||
| "version": "3.7.4" | |||
| "version": "3.6.10" | |||
EmilieDel
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in [BBS-145] we use the
dataclassdecorator for theSchemaRequestclass, but these appeared in the standard library only in python 3.7. The reason that our tests didn't fail before is because we were lucky that some of our dependencies installed thedataclassesbackport for python 3.6The
SchemaRequestclass was replaces by a new class,MiningSchema, that offers a robust and user-friendly interface.