This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Add *NRN_VERSION_* macros and variables. #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
- CORENRN_COMPATIBLE_NRN_VERSION_{MAJOR,MINOR,PATCH} are used when
CoreNEURON is built standalone, these give the NEURON version that
this CoreNEURON "corresponds to".
- Checks are added at the CMake level to make sure these values do not
drift out of sync.
- Generate a new header and define NRN_VERSION* macros that can be used
in VERBATIM blocks. Include this from coreneuron/nrnconf.h so that
these macros are implicitly available in all translated mechanisms.
olupton
force-pushed
the
olupton/version-macros
branch
from
70cc1b6 to
8f659b0
Compare
pramodk
approved these changes
Apr 11, 2022
|
New pipeline is https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/47911, the old one failed because I rebased the NEURON PR at a bad time. Hopefully once it succeeds the status will go green here 🤷 |
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* CoreNEURON version bumped to 8.2.0 to match NEURON; from now on CoreNEURON versions will track NEURON ones. - Checks are added at the CMake level to make sure these do not drift out of sync. * Add *NRN_VERSION_* macros and variables. - Based on CoreNEURON version when standalone, NEURON version when built as a submodule. - These are implicitly available in all translated mechanisms. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@0b3b9e9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the CoreNEURON counterpart of neuronsimulator/nrn#1762, which addresses neuronsimulator/nrn#1696.
NRN_VERSION*macros that can be used inVERBATIMblocks. Include this fromcoreneuron/nrnconf.hso that these macros are implicitly available in all translated mechanisms. Tests are based on the NEURON version, distinguishing between different CoreNEURON versions within the same NEURON version is not foreseen.PROJECT_VERSION_{MAJOR,MINOR,PATCH}when CoreNEURON is built standalone. This is now supposed to be kept in sync with the NEURON version.How to test this?
neuronsimulator/nrn#1762 adds a test mechanism and script that is run both in NEURON and CoreNEURON modes.
Test System
Use certain branches in CI pipelines.
CI_BRANCHES:NEURON_BRANCH=olupton/version-macros