Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Allow view specific config #201

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

nhjschulz
Copy link
Collaborator

Add a method for view specfic configuration
keys via json. The goal is to allow additional
settings (i.e. 64x64 layouts) without increasing
the footprint for others.

A new interface called IJsonConfig defines the API to use. Both plugins and views can implement it. The plugins then forward config calls to the views to have view specific settings covered (if needed).

Add a method for view specfic configuration
keys via json. The goal is to allow additional
settings (i.e. 64x64 layouts) without increasing
the  footprint for others.

A new interface called IJsonConfig defines the API
to use. Both plugins and views can implement it. The
plugins then forward config calls to the views to have
view specific settings covered (if needed).
@nhjschulz
Copy link
Collaborator Author

The change doen't fullfill its goal to save flash right now 👎

Default config:

feature/view_config:
RAM: [== ] 18.3% (used 59844 bytes from 327680 bytes)
Flash: [==========] 96.1% (used 1384965 bytes from 1441792 bytes)

Development:
RAM: [== ] 18.3% (used 59876 bytes from 327680 bytes)
Flash: [==========] 96.0% (used 1384121 bytes from 1441792 bytes)

Using it consumes more flash than it was supposed to save.
@BlueAndi
Copy link
Owner

BlueAndi commented Nov 27, 2024

@nhjschulz Please review the Swagger API update for DateTimePlugin: https://app.swaggerhub.com/apis/BlueAndi/Pixelix/1.5.0#/DateTimePlugin/getDateTimeCfg

Allow incomplete JSON input like comming from REST parameter.
@nhjschulz
Copy link
Collaborator Author

@nhjschulz Please review the Swagger API update for DateTimePlugin: https://app.swaggerhub.com/apis/BlueAndi/Pixelix/1.5.0#/DateTimePlugin/getDateTimeCfg

grafik

This should be **analogClock.**secondsMode

@BlueAndi
Copy link
Owner

BlueAndi commented Dec 1, 2024

@nhjschulz Please review the Swagger API update for DateTimePlugin: https://app.swaggerhub.com/apis/BlueAndi/Pixelix/1.5.0#/DateTimePlugin/getDateTimeCfg

grafik

This should be **analogClock.**secondsMode

Fixed.

Side:  HTML page: Removed dublicated sending of  handHourCol value.
It was moved to "analogClock" node, but forgotten to get removed
at the former position,
@nhjschulz nhjschulz marked this pull request as ready for review December 4, 2024 17:50
@nhjschulz nhjschulz requested a review from BlueAndi December 4, 2024 17:50
@BlueAndi BlueAndi merged commit c6d1188 into BlueAndi:Development Dec 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants