Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual work. Added notebook and .py files #39

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

schase15
Copy link
Contributor

Description

This PR adds my work on the visualizations for the parent dashboard. It adds the score_visual notebook which includes the various mockups we presented to Graig and Darwin. It also adds the histogram.py and line_graph.py files which create the Plotly json files for web to display on the parental dashboard. All corresponding README's have been updated.

To be implemented in the visualization endpoint of our application.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change Status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

  • Yes
  • No
  • Not necessary

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

Copy link
Contributor

@lorischl-otter lorischl-otter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the thorough documentation throughout these files. I left some PEP8 compliance notes, as well as a specific return for the event a child has 0 accepted submissions. Overall looks great though!

notebooks/README.md Outdated Show resolved Hide resolved
project/app/utils/visualizations/line_graph.py Outdated Show resolved Hide resolved
project/app/utils/visualizations/histogram.py Show resolved Hide resolved
project/app/utils/visualizations/histogram.py Show resolved Hide resolved
project/app/utils/visualizations/histogram.py Show resolved Hide resolved
Jwilson1172
Jwilson1172 previously approved these changes Oct 16, 2020
@Jwilson1172 Jwilson1172 self-requested a review October 16, 2020 15:09
Copy link
Contributor

@lorischl-otter lorischl-otter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught one small typo in the new return statement. Thanks for making the other changes!

project/app/utils/visualizations/line_graph.py Outdated Show resolved Hide resolved
lorischl-otter
lorischl-otter previously approved these changes Oct 16, 2020
Jwilson1172
Jwilson1172 previously approved these changes Oct 16, 2020
@Jwilson1172 Jwilson1172 dismissed stale reviews from lorischl-otter and themself via ae9de35 October 16, 2020 17:13
@Jwilson1172
Copy link
Contributor

oops I fixed a merge conflict in the notebooks/readme.md and now we have to resubmit the reviews, I was hoping that it would let me just merge with incoming changes

@lorischl-otter lorischl-otter merged commit 0637176 into main Oct 16, 2020
@lorischl-otter lorischl-otter deleted the feature/visualization branch October 16, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants