-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual work. Added notebook and .py files #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the thorough documentation throughout these files. I left some PEP8 compliance notes, as well as a specific return for the event a child has 0 accepted submissions. Overall looks great though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just caught one small typo in the new return statement. Thanks for making the other changes!
ae9de35
oops I fixed a merge conflict in the |
Description
This PR adds my work on the visualizations for the parent dashboard. It adds the
score_visual
notebook which includes the various mockups we presented to Graig and Darwin. It also adds thehistogram.py
andline_graph.py
files which create the Plotly json files for web to display on the parental dashboard. All corresponding README's have been updated.To be implemented in the visualization endpoint of our application.
Type of change
Change Status
Has This Been Tested
Checklist