Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordinary and x-only tweaking to spec and simplify implementation #167

Merged
merged 9 commits into from
Mar 22, 2022
Merged

Add ordinary and x-only tweaking to spec and simplify implementation #167

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f0edc90
musig: fix number of tweaks in tweak_test
jonasnick Feb 4, 2022
5b760cc
musig-spec: consistently call partial sigs psig
jonasnick Feb 7, 2022
628d52c
musig-spec: fix title/abstract and make algo names bold
jonasnick Mar 21, 2022
3aec433
musig-spec: move remarks on spec below specification section
jonasnick Mar 21, 2022
fb060a0
musig-spec: add Session Context to simplify sign/verify/sigagg
jonasnick Feb 7, 2022
aee0747
musig-spec: add general description of tweaking
jonasnick Feb 9, 2022
633d01a
musig-spec: add x-only and ordinary tweaking to musig
jonasnick Feb 4, 2022
57eb6b4
musig-spec: move description of secret key negation to spec
jonasnick Feb 9, 2022
eac0df1
musig: mention how keyagg_cache tweak and parity relate to spec
jonasnick Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
musig: fix number of tweaks in tweak_test
  • Loading branch information
@jonasnick
jonasnick committed Feb 7, 2022
commit f0edc9075539bddff2726065271c86fd7b480c9f
2 changes: 1 addition & 1 deletion src/modules/musig/tests_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ void musig_tweak_test(secp256k1_scratch_space *scratch) {
* that key. If xonly is set to true, the function f is normalizes the input
* point to have an even X-coordinate ("xonly-tweaking").
* Otherwise, the function f is the identity function. */
for (i = 1; i < N_TWEAKS; i++) {
for (i = 1; i <= N_TWEAKS; i++) {
unsigned char tweak[32];
int P_parity;
int xonly = secp256k1_testrand_bits(1);
Expand Down