Code

Sync Upstream#159

Code

Merged

real-or-random merged 131 commits intoBlockstreamResearch:masterBlockstreamResearch/secp256k1-zkp:masterfrom jonasnick:temp-merge-1029jonasnick/secp256k1-zkp:temp-merge-1029Copy head branch name to clipboardJan 5, 2022

+11,649-1,928

Commits

Commits on Sep 10, 2020

• Avoid overly-wide multiplications

  peterdettman

  committed
  b53e0cd

  Copy full SHA for b53e0cd

Commits on Jun 16, 2021

• Avoid computing out-of-bounds pointer.

  Show description for 9be7b0f
  real-or-random

  committed
  9be7b0f

  Copy full SHA for 9be7b0f

Commits on Sep 11, 2021

• Make aux_rand32 arg to secp256k1_schnorrsig_sign const

  sipa

  committed
  db4667d

  Copy full SHA for db4667d

Commits on Oct 2, 2021

• tests: remove secp256k1_fe_verify from tests.c and modify secp256k1_fe_from_storage to call secp256k1_fe_verify

  Show description for d439937
  siv2r

  committed
  d439937

  Copy full SHA for d439937

Commits on Oct 4, 2021

• Merge bitcoin-core/secp256k1#986: tests: remove secp256k1_fe_verify from tests.c and modify _fe_from_storage to call _fe_verify

  Show description for da0092b
  jonasnick

  committed
  da0092b

  Copy full SHA for da0092b

• Fix unused parameter warnings when building without VERIFY

  jonasnick

  committed
  189f6bc

  Copy full SHA for 189f6bc

Commits on Oct 12, 2021

• Merge bitcoin-core/secp256k1#987: Fix unused parameter warnings when building without VERIFY

  Show description for 10f9bd8
  real-or-random

  committed
  10f9bd8

  Copy full SHA for 10f9bd8

Commits on Oct 14, 2021

• Remove OpenSSL testing support

  sipa

  committed
  bc08599

  Copy full SHA for bc08599

Commits on Oct 15, 2021

• Make _set_fe_int( . , 0 ) set magnitude to 0

  

  real-or-random

  authored and

  roconnor-blockstream

  committed
  d49011f

  Copy full SHA for d49011f

• VERIFY_CHECK precondition for secp256k1_fe_set_int.

  roconnor-blockstream

  committed
  2888640

  Copy full SHA for 2888640

• Merge bitcoin-core/secp256k1#966: Make aux_rand32 arg to secp256k1_schnorrsig_sign const

  Show description for 297ce82
  jonasnick

  committed
  297ce82

  Copy full SHA for 297ce82

Commits on Oct 16, 2021

• Merge bitcoin-core/secp256k1#983: [RFC] Remove OpenSSL testing support

  Show description for f34b5ca
  real-or-random

  committed
  f34b5ca

  Copy full SHA for f34b5ca

Commits on Oct 17, 2021

• Merge bitcoin-core/secp256k1#952: Avoid computing out-of-bounds pointer.

  Show description for 920a0e5
  real-or-random

  committed
  920a0e5

  Copy full SHA for 920a0e5

• Merge bitcoin-core/secp256k1#810: Avoid overly-wide multiplications in 5x52 field mul/sqr

  Show description for 9526874
  real-or-random

  committed
  9526874

  Copy full SHA for 9526874

Commits on Oct 19, 2021

• Shared benchmark format for command line and CSV outputs

  Show description for 26a255b
  siv2r

  committed
  26a255b

  Copy full SHA for 26a255b

• create csv file from the benchmark output

  siv2r

  committed
  b4b1306

  Copy full SHA for b4b1306

Commits on Oct 20, 2021

• Fix G.y parity in sage code

  sipa

  committed
  044d956

  Copy full SHA for 044d956

• Merge bitcoin-core/secp256k1#996: Fix G.y parity in sage code

  Show description for aa1b889
  real-or-random

  committed
  aa1b889

  Copy full SHA for aa1b889

Commits on Oct 22, 2021

• Merge bitcoin-core/secp256k1#989: Shared benchmark format for command line and CSV outputs

  Show description for 20d791e
  jonasnick

  committed
  20d791e

  Copy full SHA for 20d791e

Commits on Oct 24, 2021

• bench_ecmult: improve clarity of output

  Show description for 96b1ad2
  jonasnick

  committed
  96b1ad2

  Copy full SHA for 96b1ad2

• bench: don't return 1 in have_flag() if argc = 1

  Show description for 23e2f66
  jonasnick

  committed
  23e2f66

  Copy full SHA for 23e2f66

Commits on Oct 25, 2021

• Merge bitcoin-core/secp256k1#999: bench_ecmult: improve clarity of output

  Show description for 3e7b2ea
  real-or-random

  committed
  3e7b2ea

  Copy full SHA for 3e7b2ea

Commits on Oct 28, 2021

• Merge bitcoin-core/secp256k1#943: VERIFY_CHECK precondition for secp256k1_fe_set_int.

  Show description for 21c188b
  real-or-random

  committed
  21c188b

  Copy full SHA for 21c188b

Commits on Oct 30, 2021

• Make aux_rnd32==NULL behave identical to 0x0000..00.

  Show description for 5324f89
  sipa

  committed
  5324f89

  Copy full SHA for 5324f89

Commits on Oct 31, 2021

• Merge bitcoin-core/secp256k1#1002: Make aux_rnd32==NULL behave identical to 0x0000..00.

  Show description for 8fa4120
  real-or-random

  committed
  8fa4120

  Copy full SHA for 8fa4120

Commits on Nov 5, 2021

• Combine bench_sign and bench_verify into single bench

  sipa

  committed
  2a7be67

  Copy full SHA for 2a7be67

• Merge bench_ecdh into bench

  sipa

  committed
  855e18d

  Copy full SHA for 855e18d

• Merge bench_recover into bench

  sipa

  committed
  3208557

  Copy full SHA for 3208557

• Merge bench_schnorrsig into bench

  sipa

  committed
  9f56bdf

  Copy full SHA for 9f56bdf

• Make bench support selecting which benchmarks to run

  sipa

  committed
  af6abcb

  Copy full SHA for af6abcb

Commits on Nov 8, 2021

• Merge bitcoin-core/secp256k1#991: Merge all "external" benchmarks into a single bench binary

  Show description for 515a5db
  real-or-random

  committed
  515a5db

  Copy full SHA for 515a5db

• doc: Replace apoelstra's GPG key by jonasnick's GPG key

  Show description for 73a7472
  real-or-random

  committed
  73a7472

  Copy full SHA for 73a7472

• doc: Suggest keys.openpgp.org as keyserver in SECURITY.md

  Show description for 3b157c4
  real-or-random

  committed
  3b157c4

  Copy full SHA for 3b157c4

Commits on Nov 9, 2021

• Merge bitcoin-core/secp256k1#1007: doc: Replace apoelstra's GPG key by jonasnick's GPG key

  Show description for c74a7b7
  real-or-random

  committed
  c74a7b7

  Copy full SHA for c74a7b7

• refactor: Use (int)&(int) in boolean context to avoid compiler warning

  Show description for 16d1322
  

  MarcoFalke

  committed
  16d1322

  Copy full SHA for 16d1322

• Merge bitcoin-core/secp256k1#1009: refactor: Use (int)&(int) in boolean context to avoid compiler warning

  Show description for 74c34e7
  real-or-random

  committed
  74c34e7

  Copy full SHA for 74c34e7

Commits on Nov 10, 2021

• ci: Enable -g if we set CFLAGS manually

  Show description for 72de135
  real-or-random

  committed
  72de135

  Copy full SHA for 72de135

• Merge bitcoin-core/secp256k1#1011: ci: Enable -g if we set CFLAGS manually

  Show description for 7006f1b
  jonasnick

  committed
  7006f1b

  Copy full SHA for 7006f1b

Commits on Nov 13, 2021

• Fix typos

  rex4539

  committed
  2332975

  Copy full SHA for 2332975

• Merge bitcoin-core/secp256k1#1012: Fix typos

  Show description for ea5e8a9
  real-or-random

  committed
  ea5e8a9

  Copy full SHA for ea5e8a9

Commits on Nov 16, 2021

• doc: Minor fixes in safegcd_implementation.md

  robot-dreams

  committed
  dc9b685

  Copy full SHA for dc9b685

Commits on Nov 17, 2021

• Merge bitcoin-core/secp256k1#1010: doc: Minor fixes in safegcd_implementation.md

  Show description for 793ad90
  real-or-random

  committed
  793ad90

  Copy full SHA for 793ad90

Commits on Nov 19, 2021

• ecmult_gen: Move table creation to new file and force static prec

  real-or-random

  committed
  22dc2c0

  Copy full SHA for 22dc2c0

• refactor: Decouple table generation and ecmult_gen context

  real-or-random

  committed
  e43ba02

  Copy full SHA for e43ba02

Commits on Nov 23, 2021

• build: don't append valgrind CPPFLAGS if not installed

  fanquake

  committed
  214042a

  Copy full SHA for 214042a

Commits on Nov 24, 2021

• doc: remove use of 0xa0 "no break space"

  fanquake

  committed
  812ff5c

  Copy full SHA for 812ff5c

• Merge bitcoin-core/secp256k1#1020: doc: remove use of <0xa0> "no break space"

  Show description for 2e5e4b6
  real-or-random

  committed
  2e5e4b6

  Copy full SHA for 2e5e4b6

• Merge bitcoin-core/secp256k1#1019: build: don't append valgrind CPPFLAGS if not installed (macOS)

  Show description for fecf436
  real-or-random

  committed
  fecf436

  Copy full SHA for fecf436

Commits on Nov 30, 2021

• ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS

  Show description for 60bf889
  jonasnick

  committed
  60bf889

  Copy full SHA for 60bf889

Commits on Dec 2, 2021

• build: pass win32-dll to LT_INIT

  Show description for fe32a79
  fanquake

  committed
  fe32a79

  Copy full SHA for fe32a79

• build: add -no-undefined to libtool LDFLAGS

  Show description for c0cd7de
  fanquake

  committed
  c0cd7de

  Copy full SHA for c0cd7de

• Merge bitcoin-core/secp256k1#1004: ecmult: fix definition of STRAUSS_SCRATCH_OBJECTS

  Show description for 49f608d
  real-or-random

  committed
  49f608d

  Copy full SHA for 49f608d

Commits on Dec 3, 2021

• build: replace backtick command substitution with $()

  Show description for 2b7c749
  

  fanquake

  and

  hebasto

  committed
  2b7c749

  Copy full SHA for 2b7c749

• ecmult_gen: Simplify ecmult_gen context after making table static

  Show description for 3b0c218
  real-or-random

  committed
  3b0c218

  Copy full SHA for 3b0c218

• ecmult_gen: Make code consistent with comment

  Show description for 00d2fa1
  real-or-random

  committed
  00d2fa1

  Copy full SHA for 00d2fa1

• refactor: Rename file that contains static ecmult_gen table

  real-or-random

  committed
  8ae18f1

  Copy full SHA for 8ae18f1

• refactor: Rename program that generates static ecmult_gen table

  real-or-random

  committed
  9ad09f6

  Copy full SHA for 9ad09f6

• refactor: Make generator a parameter of ecmult_gen_create_prec_table

  real-or-random

  committed
  e1a7653

  Copy full SHA for e1a7653

• exhaustive_tests: Fix with ecmult_gen table with custom generator

  real-or-random

  committed
  5106226

  Copy full SHA for 5106226

• doc: Remove obsolete hint for valgrind stack size

  Show description for 4c94c55
  real-or-random

  committed
  4c94c55

  Copy full SHA for 4c94c55

• refactor: Move default callbacks to util.h

  real-or-random

  committed
  a4875e3

  Copy full SHA for a4875e3

• build: Add a check that Valgrind actually supports a host platform

  hebasto

  committed
  7c7ce87

  Copy full SHA for 7c7ce87

• Merge bitcoin-core/secp256k1#1025: build: replace backtick command substitution with $()

  Show description for 4900227
  real-or-random

  committed
  4900227

  Copy full SHA for 4900227

• Verify that secp256k1_ge_set_gej_zinv does not operate on infinity.

  Show description for 6c0be85
  roconnor-blockstream

  committed
  6c0be85

  Copy full SHA for 6c0be85

• Comment and check a parameter for inf in secp256k1_ecmult_const.

  roconnor-blockstream

  committed
  099bad9

  Copy full SHA for 099bad9

Commits on Dec 4, 2021

• bench: add --help option to bench.

  Show description for dcbe84b
  siv2r

  committed
  dcbe84b

  Copy full SHA for dcbe84b

• ci: move test environment variable declaration to .cirrus.yml

  Show description for 592661c
  siv2r

  committed
  592661c

  Copy full SHA for 592661c

Commits on Dec 5, 2021

• Merge bitcoin-core/secp256k1#1008: bench.c: add --help option and ci: move env variables

  Show description for 6ad908a
  real-or-random

  committed
  6ad908a

  Copy full SHA for 6ad908a

• Merge bitcoin-core/secp256k1#1027: build: Add a check that Valgrind actually supports a host platform

  Show description for 4f01840
  real-or-random

  committed
  4f01840

  Copy full SHA for 4f01840

• Merge bitcoin-core/secp256k1#1022: build: Windows DLL additions

  Show description for 61ae37c
  real-or-random

  committed
  61ae37c

  Copy full SHA for 61ae37c

• Test ecmult functions for all i*2^j for j=0..255 and odd i=1..255.

  sipa

  committed
  e2cf773

  Copy full SHA for e2cf773

• ci: reduce TEST_ITERS in memcheck run

  sipa

  committed
  5eb519e

  Copy full SHA for 5eb519e

• refactor: Make PREC_BITS a parameter of ecmult_gen_build_prec_table

  real-or-random

  committed
  fdb33dd

  Copy full SHA for fdb33dd

Commits on Dec 6, 2021

• Merge bitcoin-core/secp256k1#920: Test all ecmult functions with many j*2^i combinations

  Show description for 486205a
  real-or-random

  committed
  486205a

  Copy full SHA for 486205a

Commits on Dec 7, 2021

• Merge bitcoin-core/secp256k1#942: Verify that secp256k1_ge_set_gej_zinv does not operate on infinity.

  Show description for 5d0dbef
  real-or-random

  committed
  5d0dbef

  Copy full SHA for 5d0dbef

Commits on Dec 9, 2021

• ecmult_gen: Precompute tables for all values of ECMULT_GEN_PREC_BITS

  real-or-random

  committed
  5eba83f

  Copy full SHA for 5eba83f

• ecmult_gen: Tidy precomputed file and save space

  real-or-random

  committed
  6573c08

  Copy full SHA for 6573c08

• prealloc: Get rid of manual memory management for prealloc contexts

  real-or-random

  committed
  ac49361

  Copy full SHA for ac49361

• build: Prebuild and distribute ecmult_gen table

  Show description for ad63bb4
  real-or-random

  committed
  ad63bb4

  Copy full SHA for ad63bb4

• build: Remove CC_FOR_BUILD stuff

  real-or-random

  committed
  d94a37a

  Copy full SHA for d94a37a

• ci: Test make precomp

  real-or-random

  committed
  bb36fe9

  Copy full SHA for bb36fe9

• build: Remove #undef hack for ASM in the precomputation programs

  Show description for 7dfcece
  real-or-random

  committed
  7dfcece

  Copy full SHA for 7dfcece

Commits on Dec 15, 2021

• Merge bitcoin-core/secp256k1#988: Make signing table fully static

  Show description for 0559fc6
  real-or-random

  committed
  0559fc6

  Copy full SHA for 0559fc6

Commits on Dec 17, 2021

• Rename gen_ecmult_gen_static_prec_table -> precompute_ecmult_gen

  sipa

  committed
  bae7768

  Copy full SHA for bae7768

• Rename gen_ecmult_static_pre_g -> precompute_ecmult

  sipa

  committed
  f95b810

  Copy full SHA for f95b810

• Rename ecmult_gen_static_prec_table -> precomputed_ecmult_gen

  sipa

  committed
  7cf47f7

  Copy full SHA for 7cf47f7

• Rename ecmult_static_pre_g -> precomputed_ecmult

  sipa

  committed
  075252c

  Copy full SHA for 075252c

• Rename ecmult_gen_prec -> ecmult_gen_compute_table

  sipa

  committed
  725370c

  Copy full SHA for 725370c

Commits on Dec 18, 2021

• Rename function secp256k1_ecmult_gen_{create_prec -> compute}_table

  sipa

  committed
  31feab0

  Copy full SHA for 31feab0

• Split ecmult table computation and printing

  sipa

  committed
  fc1bf9f

  Copy full SHA for fc1bf9f

• Move ecmult table computation code to separate file

  sipa

  committed
  e458ec2

  Copy full SHA for e458ec2

• Compute ecmult tables at runtime for tests_exhaustive

  sipa

  committed
  38cd84a

  Copy full SHA for 38cd84a

• Simplify precompute_ecmult_print_*

  sipa

  committed
  bb36331

  Copy full SHA for bb36331

• Split off .c file from precomputed_ecmult_gen.h

  sipa

  committed
  1a6691a

  Copy full SHA for 1a6691a

• Split off .c file from precomputed_ecmult.h

  sipa

  committed
  19d96e1

  Copy full SHA for 19d96e1

• Cleanup preprocessor indentation in precompute{,d}_ecmult{,_gen}

  sipa

  committed
  c45386d

  Copy full SHA for c45386d

• Fix c++ build

  sipa

  committed
  e05da9e

  Copy full SHA for e05da9e

Commits on Dec 20, 2021

• Merge bitcoin-core/secp256k1#1042: Follow-ups to making all tables fully static

  Show description for be6944a
  real-or-random

  committed
  be6944a

  Copy full SHA for be6944a

• precompute_ecmult: Always compute all tables up to default WINDOW_G

  Show description for 10461d8
  real-or-random

  committed
  10461d8

  Copy full SHA for 10461d8

• ci: Remove STATICPRECOMPUTATION

  Show description for 26a022a
  real-or-random

  committed
  26a022a

  Copy full SHA for 26a022a

Commits on Dec 21, 2021

• Improve checks at top of _fe_negate methods

  peterdettman

  committed
  515e795

  Copy full SHA for 515e795

• Add another ecmult_multi test

  sipa

  committed
  22d25c8

  Copy full SHA for 22d25c8

Commits on Dec 22, 2021

• Merge bitcoin-core/secp256k1#816: Improve checks at top of _fe_negate methods

  Show description for a69df3a
  real-or-random

  committed
  a69df3a

  Copy full SHA for a69df3a

• ci: Test different ecmult window sizes

  real-or-random

  committed
  22382f0

  Copy full SHA for 22382f0

• ci: Update brew on macOS

  Show description for d07e301
  real-or-random

  committed
  d07e301

  Copy full SHA for d07e301

• ci: Use Cirrus "greedy" flag to use idle CPU time when available

  real-or-random

  committed
  e70acab

  Copy full SHA for e70acab

• ci: Run valgrind/memcheck tasks with 2 CPUs

  Show description for b4ac1a1
  real-or-random

  committed
  b4ac1a1

  Copy full SHA for b4ac1a1

• Merge bitcoin-core/secp256k1#1044: Add another ecmult_multi test

  Show description for b39d431
  jonasnick

  committed
  b39d431

  Copy full SHA for b39d431

• doc: Fix upper bounds + cleanup in field_5x52_impl.h comment

  robot-dreams

  committed
  58da5bd

  Copy full SHA for 58da5bd

• doc: Add comment to top of field_10x26_impl.h

  robot-dreams

  committed
  1287786

  Copy full SHA for 1287786

• Merge bitcoin-core/secp256k1#1030: doc: Fix upper bounds + cleanup in field_5x52_impl.h comment

  Show description for 0b83b20
  real-or-random

  committed
  0b83b20

  Copy full SHA for 0b83b20

• Merge bitcoin-core/secp256k1#1047: ci: Various improvements

  Show description for 09971a3
  jonasnick

  committed
  09971a3

  Copy full SHA for 09971a3

Commits on Dec 23, 2021

• build: change libsecp version from 0.1 to 0.1.0-pre

  jonasnick

  committed
  b4b02fd

  Copy full SHA for b4b02fd

• build: set library version to 0.0.0 explicitly

  jonasnick

  committed
  0bd3e42

  Copy full SHA for 0bd3e42

• doc: add release_process.md

  jonasnick

  committed
  6f42dc1

  Copy full SHA for 6f42dc1

• doc: add CHANGELOG template

  jonasnick

  committed
  3ed0d02

  Copy full SHA for 3ed0d02

• tests: Fix test whose result is implementation-defined

  Show description for 3d7cbaf
  real-or-random

  committed
  3d7cbaf

  Copy full SHA for 3d7cbaf

Commits on Dec 24, 2021

• ecmult: move _ecmult_odd_multiples_table_globalz_windowa

  Show description for 05e049b
  siv2r

  committed
  05e049b

  Copy full SHA for 05e049b

• secp256k1_testrand_int(2**N) -> secp256k1_testrand_bits(N)

  sipa

  committed
  5f2efe6

  Copy full SHA for 5f2efe6

• Use xoshiro256++ PRNG instead of RFC6979 in tests

  sipa

  committed
  77a1975

  Copy full SHA for 77a1975

• Merge bitcoin-core/secp256k1#1053: ecmult: move _ecmult_odd_multiples_table_globalz_windowa

  Show description for 9281c9f
  real-or-random

  committed
  9281c9f

  Copy full SHA for 9281c9f

Commits on Dec 25, 2021

• Merge bitcoin-core/secp256k1#964: Add release-process.md

  Show description for 423b6d1
  real-or-random

  committed
  423b6d1

  Copy full SHA for 423b6d1

• Merge bitcoin-core/secp256k1#1052: Use xoshiro256++ instead of RFC6979 for tests

  Show description for a310e79
  real-or-random

  committed
  a310e79

  Copy full SHA for a310e79

• Merge bitcoin-core/secp256k1#1054: tests: Fix test whose result is implementation-defined

  Show description for 39a36db
  real-or-random

  committed
  39a36db

  Copy full SHA for 39a36db

Commits on Dec 26, 2021

• Simpler and faster ecdh skew fixup

  peterdettman

  committed
  1515099

  Copy full SHA for 1515099

• ECDH skews by 0 or 1

  peterdettman

  committed
  8c13a9b

  Copy full SHA for 8c13a9b

• Add tests for _gej_cmov

  peterdettman

  committed
  40b624c

  Copy full SHA for 40b624c

• Fixup skew before global Z fixup

  peterdettman

  committed
  e82144e

  Copy full SHA for e82144e

Commits on Dec 31, 2021

• Merge bitcoin-core/secp256k1#1029: Simpler and faster ecdh skew fixup

  Show description for a1102b1
  sipa

  committed
  a1102b1

  Copy full SHA for a1102b1

Commits on Jan 2, 2022

• Merge commits with sync-upstream.sh

  Show description for 72c8dea
  jonasnick

  committed
  72c8dea

  Copy full SHA for 72c8dea

Commits on Jan 4, 2022

• Test APIs of funcs that need an ecmult_gen ctx with static ctx

  Show description for b7ebe64
  jonasnick

  committed
  b7ebe64

  Copy full SHA for b7ebe64