lockscreen: show device name #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
lockscreen_name
branch
from
6978869 to
89806d9
Compare
|
Truncation here does not work well because the font is not monospace. I tried a monospace font - it wastes a lot of space and looks a bit ugly. It would be best to either autoscroll the name if it is too long, or to truncate based on actual size, not based on the number of chars. I'll try that later. |
benma
force-pushed
the
lockscreen_name
branch
from
89806d9 to
a7575db
Compare
|
I changed the code to take the actual rendered size of the name into account. |
It is useful to see the name of the device before you unlock it. For example, if you have multiple BitBoxes, it is useful to know which one is inserted before entering long passwords or passphrases. The device name is not a secret, and can already be queried in the API at any time, also before unlock. Users that dislike this can change the device name in the settings to something generic.
|
Rebased. |
asi345
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to see the name of the device before you unlock it. For
example, if you have multiple BitBoxes, it is useful to know which one
is inserted before entering long passwords or passphrases.
The device name is not a secret, and can already be queried in the API
at any time, also before unlock.
Users that dislike this can change the device name in the settings to
something generic.