Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move the current container version to .containerversion #1282

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

NickeZ
Copy link
Collaborator

@NickeZ NickeZ commented Aug 20, 2024

  • Add helper make dockerpull to pull the current version of the container image.
  • make dockerinit now tags with the current version. The logic is that if you are working on the container image, you should bump the version in .containerversion.

@NickeZ NickeZ self-assigned this Aug 20, 2024
@NickeZ NickeZ requested a review from benma August 20, 2024 08:59
@NickeZ
Copy link
Collaborator Author

NickeZ commented Aug 20, 2024

I have no strong feelings about the name .containerversion. So we can change if there are any better ideas.

Copy link
Collaborator

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change scripts/dockerenv.sh too, like I mentioned here?

#1278 (comment)

* Add helper `make dockerpull` to pull the current version of the
  container image.
* `make dockerinit` now tags with the current version. The logic is that
  if you are working on the container image, you should bump the version
  in `.containerversion`.
* `make dockerdev` will now default to the specific version instead of
  `latest`
@NickeZ NickeZ force-pushed the nickez/create-containerversion branch from 6069982 to fbff72a Compare August 20, 2024 09:32
@NickeZ
Copy link
Collaborator Author

NickeZ commented Aug 20, 2024

Change scripts/dockerenv.sh too, like I mentioned here?

#1278 (comment)

done!

@NickeZ NickeZ merged commit 462cfde into BitBoxSwiss:master Aug 20, 2024
3 checks passed
@NickeZ NickeZ deleted the nickez/create-containerversion branch August 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants