Policy refactor #1228
Merged
Policy refactor #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn it into a struct containing the original policy, so we don't have to repeat it in every enum arm when we add more arms.
So it can be reused when we want to check dups in Tapscripts, when adding support for Taproot `tr(...)` descriptors/policies.
By converting the script configs into a parsed/validated form, we gain the following advantages: - for policies, we only parse/validate it once per tx, instead of also twice per input (compute pk_script, compute sighash_script), and twice for each change output (to check if it is really change and to compute the payload), making policy transactions much more efficient - the match patterns are much simpler as it removes SimpleType parsing and all the protobuf nesting and unreachable `_ => ...` patterns - we will be able to check if the script config is a Taproot policy in `is_taproot()` without parsing it once more once we add Taproot policies
asi345
approved these changes
Jun 12, 2024
Thanks. Have you checked the commit messages? The script configs preprocess commit has a long explanation. The others are to prepare adding a |
|
Oh you're right. Sorry I just missed the commit message paragraphs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.