-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP85 derived entropy for Breez SDK #1179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
ln-hot-wallet-mnemonic
branch
2 times, most recently
from
February 19, 2024 16:52
a6060e6
to
6d5239f
Compare
benma
added a commit
to benma/bitbox02-api-go
that referenced
this pull request
Feb 20, 2024
Access to the BIP85 sub-apps BIP39 and LN according to BitBoxSwiss/bitbox02-firmware#1179.
benma
added a commit
to benma/bitbox02-api-go
that referenced
this pull request
Feb 20, 2024
Access to the BIP85 sub-apps BIP39 and LN according to BitBoxSwiss/bitbox02-firmware#1179.
benma
force-pushed
the
ln-hot-wallet-mnemonic
branch
from
February 20, 2024 10:58
6d5239f
to
1509b0e
Compare
benma
added a commit
to benma/bitbox02-api-go
that referenced
this pull request
Feb 20, 2024
Access to the BIP85 sub-apps BIP39 and LN according to BitBoxSwiss/bitbox02-firmware#1179.
For now the same app as before is supported - bip39, but explicit. The empty message now returns InvalidInput - would have been a breaking change but the BIP85 API endpoint was never released (disabled by not activating the app-bip85 Rust feature). Reason: we want to add another dedicated app number for the generation of deterministic entropy for the Breez SDK Lightning hot wallet in the BitBoxApp. This will segregate keys so that BIP85-BIP39 mnemonics which the user already might use (or will use) are not unintentionally re-used and made hot in the Lightning wallet.
benma
force-pushed
the
ln-hot-wallet-mnemonic
branch
2 times, most recently
from
February 20, 2024 15:05
66fc6ba
to
d1fc7fc
Compare
benma
added a commit
to benma/bitbox02-api-go
that referenced
this pull request
Feb 20, 2024
Access to the BIP85 sub-apps BIP39 and LN according to BitBoxSwiss/bitbox02-firmware#1179.
For the generation of a mnemonic for Breez-SDK Lightning hot wallets in the BitBoxApp. Using the regular BIP85-BIP39 path like `m/83696968'/39'/0'/12'/0'` for this is problematic as a user might use the same mnemonics for something else, e.g. another cold storage wallet. In such a case, the derived mnemonic of the user would become hot without the user realizing it. For the purpose of generating entropy for a lightning hot wallet using BIP85, we should instead use a different application number dedicated to this. We are going with number `19534'`, which is unlikely to interfere with other uses. It's hex representation `0x4c4e` spells `LN` in ASCII. The BIP85 derivation would then be `m/83696968'/{app_no}/{language}'/{words}'/` as in BIP85-BIP39, but use `19534'` for the `app_no` instead of `39'`, so: m/83696968'/19534'/0'/12'/0' We restrict to only 16 byte derived entropy (equivalent of 12 words mnemonics) for LN hot wallet mnemonics for simplicity and easier recovery for users. The index represents the account number - for now we only allow `0` (the first account), and can extend to multiple if there is ever a need.
benma
force-pushed
the
ln-hot-wallet-mnemonic
branch
from
February 20, 2024 15:21
d1fc7fc
to
c7e091c
Compare
Beerosagos
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK!
benma
added a commit
to benma/bitbox02-api-go
that referenced
this pull request
Feb 20, 2024
Access to the BIP85 sub-apps BIP39 and LN according to BitBoxSwiss/bitbox02-firmware#1179.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.