Correct flash memory layouts #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
flash-memory-sizes
branch
from
cdadbb3 to
5b8ff2a
Compare
|
Please double check my math :) |
benma
requested changes
Feb 19, 2024
| @@ -35,7 +35,7 @@ SEARCH_DIR(.) | |||
| /* Memory Spaces Definitions */ | |||
| MEMORY | |||
| { | |||
| rom (rx) : ORIGIN = 0x00010000, LENGTH = 0x000F0000 | |||
| rom (rx) : ORIGIN = 0x00010000, LENGTH = 0x000D8000 | |||
There was a problem hiding this comment.
i re-computed and came to the same conclusion.
Document the actual values of the flash partition offsets and update linker scripts to match.
NickeZ
force-pushed
the
flash-memory-sizes
branch
from
5b8ff2a to
78dcbc3
Compare
benma
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the actual values of the flash partition offsets and update linker scripts to match.