Skip to content

Commit

Permalink
.ci/check-tidy: fix early abort and don't lint tests
Browse files Browse the repository at this point in the history
The check looped both build and build-build, but aborted if for build,
there were no sources to lint. This way, in many PRs the linter missed
linting the tests, which now have many warnings/errors.

We disable these for now to have CI pass and can fix the individual
issues at a later time.
  • Loading branch information
benma committed Mar 19, 2024
1 parent 2e380b2 commit 1b1dfca
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .ci/check-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ for dir in build build-build; do
# Only check our files
SOURCES1=$(git --no-pager diff --diff-filter=d --name-only ${TARGET_BRANCH} |\
grep -v -E "(^src/(drivers|ui/fonts)|.*ugui.*|.*base32.*)" |\
grep -E "^(src|test)" |\
grep -E "^(src)" |\
grep -v "^test/unit-test/u2f/" |\
grep -E "\.c\$" || true)

Expand All @@ -51,7 +51,7 @@ for dir in build build-build; do
done

if [ -z "${SOURCES}" ] ; then
exit 0
continue
fi

echo "Checking $(echo ${SOURCES} | wc -w) files with clang-tidy"
Expand Down

0 comments on commit 1b1dfca

Please sign in to comment.