feat(api): Ethereum transactions API #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for quantumbridge ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kevzzsk
reviewed
Mar 28, 2023
jordankzf
force-pushed
the
jordankzf/eth-transactions-api
branch
from
52f19d8 to
cb710f7
Compare
jordankzf
requested review from
thedoublejay,
fullstackninja864,
lykalabrada and
pierregee
as code owners
kevzzsk
suggested changes
Mar 28, 2023
apps/server/src/ethereum/services/EthereumTransactionsService.ts
Outdated
Show resolved
Hide resolved
|
LGTM but let's hold this PR for now. Pending adding JWT/security to this API |
kevzzsk
reviewed
Mar 29, 2023
kevzzsk
previously approved these changes
Mar 29, 2023
thedoublejay
suggested changes
Mar 30, 2023
jordankzf
force-pushed
the
jordankzf/eth-transactions-api
branch
from
d7a86ac to
1b96dc5
Compare
kevzzsk
reviewed
Mar 31, 2023
kevzzsk
approved these changes
Mar 31, 2023
pierregee
suggested changes
Mar 31, 2023
kevzzsk
suggested changes
Apr 3, 2023
|
Added mock transaction database entries |
pierregee
reviewed
Apr 4, 2023
jordankzf
force-pushed
the
jordankzf/eth-transactions-api
branch
from
9d36277 to
6b25afe
Compare
kevzzsk
approved these changes
Apr 4, 2023
thedoublejay
reviewed
Apr 5, 2023
| readonly timestamp: string, | ||
| readonly status: string, | ||
| readonly sendTransactionHash: string | null, | ||
| readonly unconfirmedSendTransactionHash: string | null, |
There was a problem hiding this comment.
@jordankzf Note, if you want to make it optional just add ?. To check on another PR
There was a problem hiding this comment.
Addressed here: #847 (comment)
thedoublejay
suggested changes
Apr 5, 2023
| import { buildTestConfig, TestingModule } from '../TestingModule'; | ||
|
|
||
| function verifyFormat(parsedPayload: TransactionsDto) { | ||
| expect(parsedPayload).toHaveProperty('txHash'); |
There was a problem hiding this comment.
I think this test can be improved. We need to check if the type is correct. Let's say, we updated the schema. All consumers of this API will break. So we need to know if that happens. Anyway, we can fix it on another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
/ethereum/transactions?fromDate=YYYY-MM-DD&toDate=YYYY-MM-DDendpointWhich issue(s) does this PR fixes?:
Fixes #834
Additional comments?:
Developer Checklist: