chore(core): add sanity checks in evm to dfc endpoints #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for quantumbridge ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pierregee
changed the title
pierregee
changed the title
pierregee
requested review from
thedoublejay and
fullstackninja864
as code owners
cuongquangnam
approved these changes
Mar 27, 2023
thedoublejay
approved these changes
Mar 28, 2023
thedoublejay
pushed a commit
that referenced
this pull request
Mar 28, 2023
* add another sanity check * chore(core): add sec checks in evm to dfc endpoints * use clearer variable names * remove comment * check txn validity before accessing db * pass 0 confirmations and revert name * rename comments * rename comments * revert reodering condition * fix typo * update e2e --------- Co-authored-by: cuongquangnam <[email protected]>
thedoublejay
added a commit
that referenced
this pull request
Mar 29, 2023
* feature(ui-ux): refetch hot wallet balance and transfer guard (#763) * init * refactor on transfer token flow * code cleanup * code cleanup * code cleanup -S * code cleanup * code cleanup * resolve pr comment -S * resolve pr comment * fix getBalanceFn response type * code cleanup --------- Co-authored-by: JJ Adonis <[email protected]> Co-authored-by: Pierre Gee <[email protected]> * chore(ops): enable DFI on client (#804) chore: enable DFI on client * feature(ui-ux): added liquidity overview screen (#794) * feature(ui-ux): added liquidity overview screen * added Link component * added Disclosure for mobile view * removed env variables * removed unused api endpoint * lint fix * fixed width in small screen * renamed router * added tool tip and added fetch balances on network change * minor ui updates * hide navigation when bridge is down * desc update * minor fix * minor updates * updated hotWalletAddress to HotWalletAddress * chore: update dfi label on ethereum Refactor TokenInfo prop and rename component --------- Co-authored-by: Keng Ye <[email protected]> Co-authored-by: Keng Ye <[email protected]> * chore: re-add dfi into client * feature(ui-ux): added on click event on entire token header bar while closing (#821) * feature(ui-ux): added test ids for better cypress testing on liquidity screen (#837) feature(ui-ux): added testids for better cypress testing on liquidity screen * chore(ui-ux): update warning message when balance is insufficient (#841) * feat: add reserved utxo on client form * feat: support all token for liquidity check * chore: add liquidity as dependency * revert: all previous changes Only update warning message when insufficient balance * chore(ui-ux): claim - prevent txn hook from running on load (#731) * chore(refactor): claim - prevent txn hook from running on load * fix(ui-ux): fix lint error * bump(deps): update dependency react-secure-storage to ^1.2.0 (#839) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump(deps): update @waveshq/walletkit to ^0.43.0 (#842) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump(deps): update dependency @netlify/plugin-nextjs to ^4.33.0 (#845) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(server): check for hot wallet DFI balance when crafting send tx (#843) feat: check for hot wallet DFI balance when crafting send tx * bump(deps): update dependency @fastify/compress to ^6.2.1 (#844) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(server): Add another sanity check for decodeTxnData (#811) * add another sanity check * Update apps/server/src/ethereum/services/EVMTransactionConfirmerService.ts Co-authored-by: Lee Wei Yuan <[email protected]> --------- Co-authored-by: JJ Adonis <[email protected]> Co-authored-by: Lee Wei Yuan <[email protected]> * chore(core): add sanity checks in evm to dfc endpoints (#816) * add another sanity check * chore(core): add sec checks in evm to dfc endpoints * use clearer variable names * remove comment * check txn validity before accessing db * pass 0 confirmations and revert name * rename comments * rename comments * revert reodering condition * fix typo * update e2e --------- Co-authored-by: cuongquangnam <[email protected]> * fix(ui-ux): fix disabled claim btn (#852) * fix(ui-ux): trial fix, claim btn is disabled on some machines * fix(ui-ux): fix disabled claim btn * fix(ui-ux): fix disabled claim button for eth (#853) --------- Co-authored-by: Julio Caesar <[email protected]> Co-authored-by: Pierre Gee <[email protected]> Co-authored-by: Keng Ye <[email protected]> Co-authored-by: Harsh R <[email protected]> Co-authored-by: Keng Ye <[email protected]> Co-authored-by: Lyka Labrada <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cuongquangnam <[email protected]> Co-authored-by: Lee Wei Yuan <[email protected]> Co-authored-by: Pierre Gee <[email protected]> Co-authored-by: cuongquangnam <[email protected]>
thedoublejay
added a commit
that referenced
this pull request
Apr 3, 2023
* feature(ui-ux): added liquidity overview screen * added Link component * added Disclosure for mobile view * removed env variables * removed unused api endpoint * lint fix * fixed width in small screen * renamed router * added tool tip and added fetch balances on network change * feature(ui-ux): refetch hot wallet balance and transfer guard (#763) * init * refactor on transfer token flow * code cleanup * code cleanup * code cleanup -S * code cleanup * code cleanup * resolve pr comment -S * resolve pr comment * fix getBalanceFn response type * code cleanup --------- Co-authored-by: JJ Adonis <[email protected]> Co-authored-by: Pierre Gee <[email protected]> * chore(ops): enable DFI on client (#804) chore: enable DFI on client * minor ui updates * hide navigation when bridge is down * desc update * minor fix * minor updates * updated hotWalletAddress to HotWalletAddress * added navigation check, PoB link, liquidity validation, addresses checks, basic responsiveness check for mobile elements; * update port number; * feature(ui-ux): added liquidity overview screen (#794) * feature(ui-ux): added liquidity overview screen * added Link component * added Disclosure for mobile view * removed env variables * removed unused api endpoint * lint fix * fixed width in small screen * renamed router * added tool tip and added fetch balances on network change * minor ui updates * hide navigation when bridge is down * desc update * minor fix * minor updates * updated hotWalletAddress to HotWalletAddress * chore: update dfi label on ethereum Refactor TokenInfo prop and rename component --------- Co-authored-by: Keng Ye <[email protected]> Co-authored-by: Keng Ye <[email protected]> * prettifier; * Navigation test update; * chore: re-add dfi into client * moved navigation check to mobile; add ipad viewport; * feature(ui-ux): added on click event on entire token header bar while closing (#821) * prettify; * feature(ui-ux): added test ids for better cypress testing on liquidity screen (#837) feature(ui-ux): added testids for better cypress testing on liquidity screen * chore(ui-ux): update warning message when balance is insufficient (#841) * feat: add reserved utxo on client form * feat: support all token for liquidity check * chore: add liquidity as dependency * revert: all previous changes Only update warning message when insufficient balance * chore(ui-ux): claim - prevent txn hook from running on load (#731) * chore(refactor): claim - prevent txn hook from running on load * fix(ui-ux): fix lint error * bump(deps): update dependency react-secure-storage to ^1.2.0 (#839) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump(deps): update @waveshq/walletkit to ^0.43.0 (#842) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump(deps): update dependency @netlify/plugin-nextjs to ^4.33.0 (#845) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(server): check for hot wallet DFI balance when crafting send tx (#843) feat: check for hot wallet DFI balance when crafting send tx * bump(deps): update dependency @fastify/compress to ^6.2.1 (#844) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(server): Add another sanity check for decodeTxnData (#811) * add another sanity check * Update apps/server/src/ethereum/services/EVMTransactionConfirmerService.ts Co-authored-by: Lee Wei Yuan <[email protected]> --------- Co-authored-by: JJ Adonis <[email protected]> Co-authored-by: Lee Wei Yuan <[email protected]> * chore(core): add sanity checks in evm to dfc endpoints (#816) * add another sanity check * chore(core): add sec checks in evm to dfc endpoints * use clearer variable names * remove comment * check txn validity before accessing db * pass 0 confirmations and revert name * rename comments * rename comments * revert reodering condition * fix typo * update e2e --------- Co-authored-by: cuongquangnam <[email protected]> * fix(ui-ux): fix disabled claim btn (#852) * fix(ui-ux): trial fix, claim btn is disabled on some machines * fix(ui-ux): fix disabled claim btn * fix(ui-ux): fix disabled claim button for eth (#853) * add TN/MN liquidity checks; add test ids; * added testid for navigation check; * added testid for mobile responsiveness check; * prettify; * prettify; * refactored; add network configs; * prettify; * fix lint; rename test ids;gi * rename testid; --------- Co-authored-by: Harsh <[email protected]> Co-authored-by: Keng Ye <[email protected]> Co-authored-by: Julio Caesar <[email protected]> Co-authored-by: JJ Adonis <[email protected]> Co-authored-by: Pierre Gee <[email protected]> Co-authored-by: Harsh R <[email protected]> Co-authored-by: Keng Ye <[email protected]> Co-authored-by: Lyka Labrada <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cuongquangnam <[email protected]> Co-authored-by: Lee Wei Yuan <[email protected]> Co-authored-by: Pierre Gee <[email protected]> Co-authored-by: cuongquangnam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add sanity checks if the evm transaction is valid
handleTransactionendpointallocateDfcFundendpointWhich issue(s) does this PR fixes?:
Fixes #
Additional comments?:
Developer Checklist: