Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-ux): remove eth wallet balance poll #706

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

pierregee
Copy link

@pierregee pierregee commented Mar 8, 2023

What this PR does / why we need it:

The balance will be refetched on the following events (ethereum network dropdown)

  • token changed
  • 15 seconds after confirming a txn
  • Press review txn (to make sure we are validating against the most updated balance)

Which issue(s) does this PR fixes?:

Fixes #702

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit 4da35f9
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/6408287f0147200008053fb4
😎 Deploy Preview https://deploy-preview-706--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the kind/chore Non feature change label Mar 8, 2023
@pierregee pierregee marked this pull request as ready for review March 8, 2023 06:11
@thedoublejay thedoublejay merged commit d5ad469 into main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

balance polling - add a refresh button instead of polling
2 participants