Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-ux): change to 5dp #699

Merged
merged 5 commits into from
Mar 8, 2023
Merged

fix(ui-ux): change to 5dp #699

merged 5 commits into from
Mar 8, 2023

Conversation

pierregee
Copy link

@pierregee pierregee commented Mar 8, 2023 •
edited
Loading

What this PR does / why we need it:

as titled

Which issue(s) does this PR fixes?:

Fixes #695, #693

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@netlify
Copy link

netlify bot commented Mar 8, 2023 •
edited
Loading

✅ Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit df02e87
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/6407f775babcb60008fc7a0a
😎 Deploy Preview https://deploy-preview-699--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pierregee pierregee temporarily deployed to AWS ECR March 8, 2023 02:25 — with GitHub Actions Inactive
@github-actions github-actions bot added the kind/fix Fix a bug label Mar 8, 2023
@pierregee pierregee changed the title fix(ui-ux): change to 5dp [wip] fix(ui-ux): change to 5dp Mar 8, 2023
@pierregee pierregee temporarily deployed to AWS ECR March 8, 2023 02:36 — with GitHub Actions Inactive
@pierregee pierregee marked this pull request as ready for review March 8, 2023 02:37
@pierregee pierregee temporarily deployed to AWS ECR March 8, 2023 02:48 — with GitHub Actions Inactive
@thedoublejay thedoublejay merged commit 4aa78fc into main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedoublejay thedoublejay thedoublejay approved these changes

@weiyuan95 weiyuan95 Awaiting requested review from weiyuan95

@fullstackninja864 fullstackninja864 Awaiting requested review from fullstackninja864

@lykalabrada lykalabrada Awaiting requested review from lykalabrada

@greggtan greggtan Awaiting requested review from greggtan

@kyleleow kyleleow Awaiting requested review from kyleleow

Assignees
No one assigned
Labels
kind/fix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM -> DFC = Balance - Limit display to 5 decimal places
2 participants
@pierregee @thedoublejay