Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): claim - properly parse amount based on the token #684

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

lykalabrada
Copy link
Contributor

What this PR does / why we need it:

As titled.

  • Native ETH token should use parseEther function
  • Other ERC20 tokens should use parseUnits function with the proper decimal places per token

Which issue(s) does this PR fixes?:

Fixes #679

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit 39df331
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/6407019c1910d5000805f37c
😎 Deploy Preview https://deploy-preview-684--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lykalabrada lykalabrada temporarily deployed to AWS ECR March 7, 2023 08:58 — with GitHub Actions Inactive
@github-actions github-actions bot added the kind/fix Fix a bug label Mar 7, 2023
@lykalabrada lykalabrada temporarily deployed to AWS ECR March 7, 2023 09:03 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR March 7, 2023 09:19 — with GitHub Actions Inactive
@thedoublejay thedoublejay marked this pull request as ready for review March 7, 2023 09:36
@thedoublejay thedoublejay merged commit feac638 into main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DFC → ETH: Unable to send dBTC → wBTC
2 participants