Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fix claim loop when deadline has lapsed #643

Merged
merged 7 commits into from
Mar 5, 2023

Conversation

lykalabrada
Copy link
Contributor

@lykalabrada lykalabrada commented Mar 3, 2023

What this PR does / why we need it:

  • Fix claim loop when deadline has lapsed, show an error modal instead
  • Display timer for claim validity

Which issue(s) does this PR fixes?:

Fixes #639

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit d08aa94
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/640350d26c3ed400074416a0
😎 Deploy Preview https://deploy-preview-643--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the kind/fix Fix a bug label Mar 3, 2023
@lykalabrada lykalabrada changed the title fix(web): fix claim loop when deadline has lapsed fix(web): fix claim loop when deadline has lapsed [Not Ready] Mar 3, 2023
@lykalabrada lykalabrada marked this pull request as ready for review March 4, 2023 14:11
@lykalabrada lykalabrada changed the title fix(web): fix claim loop when deadline has lapsed [Not Ready] fix(web): fix claim loop when deadline has lapsed Mar 4, 2023
@thedoublejay thedoublejay merged commit 34e69bf into main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Claim tokens loop - after 24hr when MetaMask gets disconnected from browser
2 participants