Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): verify amount with max 6 decimal #641

Merged
merged 4 commits into from
Mar 3, 2023
Merged

fix(api): verify amount with max 6 decimal #641

merged 4 commits into from
Mar 3, 2023

Conversation

JoshuaC817
Copy link
Contributor

@JoshuaC817 JoshuaC817 commented Mar 3, 2023 •
edited
Loading

What this PR does / why we need it:

Check for /verify api only allow max 6 decimal places for amount

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@JoshuaC817 JoshuaC817 self-assigned this Mar 3, 2023
@JoshuaC817 JoshuaC817 temporarily deployed to AWS ECR March 3, 2023 04:19 — with GitHub Actions Inactive
@netlify
Copy link

netlify bot commented Mar 3, 2023 •
edited
Loading

✅ Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit cf2a11c
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/6401921e0ad6d8000814497b
😎 Deploy Preview https://deploy-preview-641--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the kind/fix Fix a bug label Mar 3, 2023
@JoshuaC817 JoshuaC817 temporarily deployed to AWS ECR March 3, 2023 04:26 — with GitHub Actions Inactive
@pierregee pierregee marked this pull request as draft March 3, 2023 05:07
@JoshuaC817 JoshuaC817 temporarily deployed to AWS ECR March 3, 2023 06:22 — with GitHub Actions Inactive
@JoshuaC817 JoshuaC817 marked this pull request as ready for review March 3, 2023 06:25
@thedoublejay thedoublejay merged commit 4566f22 into main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@weiyuan95 weiyuan95 Awaiting requested review from weiyuan95

@fullstackninja864 fullstackninja864 Awaiting requested review from fullstackninja864

@lykalabrada lykalabrada Awaiting requested review from lykalabrada

@greggtan greggtan Awaiting requested review from greggtan

@pierregee pierregee Awaiting requested review from pierregee

Assignees
No one assigned
Labels
kind/fix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaC817 @thedoublejay