Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add /settings api for settings shared with frontend #637

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

lykalabrada
Copy link
Contributor

@lykalabrada lykalabrada commented Mar 3, 2023

What this PR does / why we need it:

  • Added /settings api to return shared config between server and frontend
  • Integrated settings api to Fees computation (UI)
  • TODO [web]: Get supportedTokens from /settings api to filter out displayed tokens on the bridge form
  • TODO [web]: Check other places where fees is used, remove constants
  • TODO [api]: Use same supportedTokens to allow/disallow tokens on all API that uses tokens

Which issue(s) does this PR fixes?:

Fixes #638

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit a8fdba0
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/640159eeefa8d30007d1c822
😎 Deploy Preview https://deploy-preview-637--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the kind/feature New feature request label Mar 3, 2023
@virgchiniwala virgchiniwala mentioned this pull request Mar 3, 2023
5 tasks
@thedoublejay thedoublejay merged commit 934b018 into main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported Tokens List
2 participants