feat(Smart contracts): Fix solidity version + more tests #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuongquangnam
requested review from
thedoublejay,
weiyuan95,
lykalabrada,
pierregee and
Abhishekkochar
as code owners
✅ Deploy Preview for quantumbridge ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cuongquangnam
changed the title
weiyuan95
reviewed
Mar 2, 2023
| 25 * 60 * 60, | ||
| ), | ||
| ).to.revertedWith('TimelockController: operation already scheduled'); | ||
| }); | ||
|
|
||
| it('Change the salt, the operation should be successfully scheduled and later executed', async () => { |
There was a problem hiding this comment.
Would it revert if we use the same salt? 🤔
There was a problem hiding this comment.
ah, so the salt is calculated this way:
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.8.1/contracts/governance/TimelockController.sol#L194
so let's say if target, value, data, predecessor, salt are the same --> we get a hash that has been scheduled or done --> getTimestamp(hash) > 0 --> schedule will revert (
the check over here
weiyuan95
reviewed
Mar 2, 2023
…hain to send tokens to the defiAddress anymore
weiyuan95
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #293
Additional comments?:
Developer Checklist: