Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ReadMe): Updated with correct addresses and user guide on new implementation #622

Merged
merged 14 commits into from
Mar 7, 2023
Merged

docs(ReadMe): Updated with correct addresses and user guide on new implementation #622

merged 14 commits into from
Mar 7, 2023

Conversation

Abhishekkochar
Copy link
Contributor

@Abhishekkochar Abhishekkochar commented Mar 2, 2023 •
edited
Loading

What this PR does / why we need it:

  • Updated read me with correct address version 5.
  • Time lock contract role info

Which issue(s) does this PR fixes?:

Fixes #624

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit bcdcd26
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/6406ef346dca1f0009be67f1
😎 Deploy Preview https://deploy-preview-622--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 2, 2023 04:33 — with GitHub Actions Inactive
@github-actions github-actions bot added the kind/docs Non feature documentation change label Mar 2, 2023
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 2, 2023 05:44 — with GitHub Actions Inactive
@Abhishekkochar Abhishekkochar marked this pull request as ready for review March 2, 2023 06:16
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 2, 2023 07:00 — with GitHub Actions Inactive
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 2, 2023 10:13 — with GitHub Actions Inactive
weiyuan95
weiyuan95 reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 3, 2023 02:35 — with GitHub Actions Inactive
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 3, 2023 03:04 — with GitHub Actions Inactive
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 3, 2023 03:14 — with GitHub Actions Inactive
@Abhishekkochar Abhishekkochar requested a review from weiyuan95 March 3, 2023 05:40
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 3, 2023 05:45 — with GitHub Actions Inactive
cuongquangnam
cuongquangnam suggested changes Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 3, 2023 09:08 — with GitHub Actions Inactive
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 5, 2023 23:48 — with GitHub Actions Inactive
cuongquangnam
cuongquangnam suggested changes Mar 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 6, 2023 07:27 — with GitHub Actions Inactive
cuongquangnam
cuongquangnam suggested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@cuongquangnam cuongquangnam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the changes I suggest below, everything else LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Abhishekkochar Abhishekkochar temporarily deployed to AWS ECR March 7, 2023 06:10 — with GitHub Actions Inactive
cuongquangnam
cuongquangnam previously approved these changes Mar 7, 2023
View reviewed changes
weiyuan95
weiyuan95 reviewed Mar 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@weiyuan95 weiyuan95 temporarily deployed to AWS ECR March 7, 2023 08:00 — with GitHub Actions Inactive
@weiyuan95 weiyuan95 merged commit 064dee7 into main Mar 7, 2023
@weiyuan95 weiyuan95 deleted the abhishek/v5deployment branch March 7, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiyuan95 weiyuan95 weiyuan95 approved these changes

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@lykalabrada lykalabrada Awaiting requested review from lykalabrada

@pierregee pierregee Awaiting requested review from pierregee

@cuongquangnam cuongquangnam Awaiting requested review from cuongquangnam

Assignees
No one assigned
Labels
kind/docs Non feature documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EVM -> DFC] Change TX fees variable to 0
3 participants
@Abhishekkochar @weiyuan95 @cuongquangnam