Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove connectkit workaround #1216

Merged
merged 21 commits into from
Aug 28, 2023
Merged

chore(core): remove connectkit workaround #1216

merged 21 commits into from
Aug 28, 2023

Conversation

lykalabrada
Copy link
Contributor

What this PR does / why we need it:

Removing workaround fix that was added on this PR #1211

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@lykalabrada lykalabrada self-assigned this Aug 28, 2023
@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit 0ec69b1
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/64ec9b6a79f9980008da68bc
😎 Deploy Preview https://deploy-preview-1216--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 06:50 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 06:50 — with GitHub Actions Inactive
@github-actions github-actions bot added the kind/chore Non feature change label Aug 28, 2023
thedoublejay
thedoublejay previously approved these changes Aug 28, 2023
View reviewed changes
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 09:50 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 09:50 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 10:14 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 10:14 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 10:25 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 10:25 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 11:05 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 11:05 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:09 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:09 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:17 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:17 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:35 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:35 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:48 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:48 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:56 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 12:56 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 13:04 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 13:04 — with GitHub Actions Inactive
@thedoublejay thedoublejay merged commit 423ab71 into main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedoublejay thedoublejay thedoublejay approved these changes

@kyleleow kyleleow Awaiting requested review from kyleleow

@fullstackninja864 fullstackninja864 Awaiting requested review from fullstackninja864

@pierregee pierregee Awaiting requested review from pierregee

@cuongquangnam cuongquangnam Awaiting requested review from cuongquangnam

Assignees
No one assigned
Labels
kind/chore Non feature change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lykalabrada @thedoublejay