Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): add new matic, sol and dot tokens to config #1204

Merged
merged 17 commits into from
Aug 28, 2023
Merged

feat(server): add new matic, sol and dot tokens to config #1204

merged 17 commits into from
Aug 28, 2023

Conversation

lykalabrada
Copy link
Contributor

@lykalabrada lykalabrada commented Aug 21, 2023 •
edited
Loading

What this PR does / why we need it:

Adding new tokens: MATIC, SOL and DOT.
Related PR for frontend changes: #1206

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Currently blocked, still waiting for the following:

  • DeFiChain test Ids for new tokens on Playground (Ids are created for Mainnet and Testnet)

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@lykalabrada lykalabrada self-assigned this Aug 21, 2023
@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited
Loading

✅ Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit d45c5a4
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/64ec9e80b3287500084cf8d1
😎 Deploy Preview https://deploy-preview-1204--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lykalabrada lykalabrada changed the title feat(core): add new matic, sol and dot tokens to config [NOT READY] feat(server): add new matic, sol and dot tokens to config [NOT READY] Aug 21, 2023
@github-actions github-actions bot added the kind/feature New feature request label Aug 21, 2023
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 07:01 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 07:01 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 08:26 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 08:26 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 09:23 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 09:23 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 10:47 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 10:47 — with GitHub Actions Inactive
@lykalabrada lykalabrada mentioned this pull request Aug 21, 2023
Merged
7 tasks
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 11:20 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 21, 2023 11:20 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 22, 2023 03:44 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 22, 2023 03:44 — with GitHub Actions Inactive
@lykalabrada lykalabrada changed the title feat(server): add new matic, sol and dot tokens to config [NOT READY] feat(server): add new matic, sol and dot tokens to config Aug 22, 2023
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 22, 2023 10:38 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 22, 2023 10:38 — with GitHub Actions Inactive
thedoublejay
thedoublejay suggested changes Aug 28, 2023
View reviewed changes
apps/server/.env Outdated Show resolved Hide resolved
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 05:30 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 05:30 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 05:48 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 05:48 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 07:22 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 07:22 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 09:40 — with GitHub Actions Inactive
@lykalabrada lykalabrada temporarily deployed to AWS ECR August 28, 2023 09:40 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 13:17 — with GitHub Actions Inactive
@thedoublejay thedoublejay temporarily deployed to AWS ECR August 28, 2023 13:17 — with GitHub Actions Inactive
@thedoublejay thedoublejay marked this pull request as ready for review August 28, 2023 13:18
@thedoublejay thedoublejay merged commit 99bfd1e into main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloezxyy chloezxyy chloezxyy left review comments

@thedoublejay thedoublejay thedoublejay requested changes

@cuongquangnam cuongquangnam Awaiting requested review from cuongquangnam

@fullstackninja864 fullstackninja864 Awaiting requested review from fullstackninja864

@pierregee pierregee Awaiting requested review from pierregee

Assignees
No one assigned
Labels
kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lykalabrada @thedoublejay @chloezxyy