Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ops): fix workflow to build ecr image #27

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

chloezxyy
Copy link

@chloezxyy chloezxyy commented Mar 18, 2024

What this PR does / why we need it:

  • Add wait-for script to handle dependencies between services
  • Import ethers library for smartcontracts build
  • Run pnpm dev in root to start app

Which issue(s) does this PR fixes?:

Fixes MarbleFi-

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for marblefi ready!

Name Link
🔨 Latest commit 1962b1d
🔍 Latest deploy log https://app.netlify.com/sites/marblefi/deploys/65f7cfb5c6767b00085be6b5
😎 Deploy Preview https://deploy-preview-27--marblefi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chloezxyy chloezxyy changed the title chore(ops): install semver in release-apps.yml chore(ops): fix release apps to build ecr image Mar 18, 2024
@chloezxyy chloezxyy changed the title chore(ops): fix release apps to build ecr image chore(ops): fix workflow to build ecr image Mar 18, 2024
@chloezxyy chloezxyy marked this pull request as draft March 18, 2024 03:39
@chloezxyy chloezxyy marked this pull request as ready for review March 18, 2024 05:34
@pierregee pierregee merged commit b7ebefd into main Mar 18, 2024
8 checks passed
@pierregee pierregee deleted the chloe/github-actions-semver branch March 18, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants