Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "{%UserProfile}\Grabber" from the Uninstaller #3347

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Remove "{%UserProfile}\Grabber" from the Uninstaller #3347

merged 5 commits into from
Jan 2, 2025

Conversation

ProtagNeptune
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.76%. Comparing base (fe3a514) to head (78cd0ab).

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop    #3347    +/-   ##
=========================================
  Coverage    32.76%   32.76%            
=========================================
  Files          384      384            
  Lines        24153    24153            
  Branches      3541     3539     -2     
=========================================
  Hits          7914     7914            
- Misses       16121    16238   +117     
+ Partials       118        1   -117

@ProtagNeptune ProtagNeptune changed the title Update setup.iss Put the "{%UserProfile}\Grabber" into the Pop-up to ask to delete AppData settings Dec 29, 2024
@ProtagNeptune ProtagNeptune changed the title Put the "{%UserProfile}\Grabber" into the Pop-up to ask to delete AppData settings Put the "{%UserProfile}\Grabber" into the "Pop-up to ask to delete AppData settings" Dec 29, 2024
@ProtagNeptune
Copy link
Contributor Author

Hey @Bionus, I think this should fix the bug that happened to me. 🤔

@Bionus
Copy link
Owner

Bionus commented Jan 2, 2025

@ProtagNeptune TBH given {%UserProfile}\Grabber hasn't been used for storing settings in forever, might as well just totally remove it from the uninstaller as well. Otherwise what happened to you might also happen accidentally to someone who wants to delete their settings, but not their files they might have saved in {%UserProfile}\Grabber 😄

@ProtagNeptune ProtagNeptune changed the title Put the "{%UserProfile}\Grabber" into the "Pop-up to ask to delete AppData settings" Remove "{%UserProfile}\Grabber" from the Uninstaller Jan 2, 2025
@Bionus Bionus self-requested a review January 2, 2025 17:55
Bionus
Bionus approved these changes Jan 2, 2025
View reviewed changes
Copy link
Owner

@Bionus Bionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Bionus Bionus merged commit 885f6e8 into Bionus:develop Jan 2, 2025
8 of 10 checks passed
@ProtagNeptune ProtagNeptune deleted the patch-1 branch January 2, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bionus Bionus Bionus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProtagNeptune @Bionus