-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update log-tab.ui #3219
Update log-tab.ui #3219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3219 +/- ##
=========================================
Coverage 32.63% 32.63%
=========================================
Files 384 384
Lines 22353 22353
Branches 3528 3528
=========================================
Hits 7296 7296
- Misses 14940 15056 +116
+ Partials 117 1 -116 |
Oops...sorry for the commits spam? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the UI file, but did you update the .ts
files by hand? 😅
There's a CMake command for that, that'd be not only easier but it'd avoid having incorrect translations like now in Russian for example:
<source>Open log folder</source>
<translation>Открыть каталог настроек</translation>
The old one should be marked as missing and a new one created AFAIK. I'll run the command on your PR 👍
Yeah, I changed those files before finding out about the codespace thing so I did it one by one...
Sorry about that. Should it be something like that now?
|
FWIW, the easiest way to update those files in a correct way is to build the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
#3218