Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log-tab.ui #3219

Merged
merged 19 commits into from
Jul 1, 2024
Merged

Update log-tab.ui #3219

merged 19 commits into from
Jul 1, 2024

Conversation

ProtagNeptune
Copy link
Contributor

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.63%. Comparing base (fef4a94) to head (ee50203).
Report is 1 commits behind head on develop.

Current head ee50203 differs from pull request most recent head 424a3f9

Please upload reports for the commit 424a3f9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #3219    +/-   ##
=========================================
  Coverage    32.63%   32.63%            
=========================================
  Files          384      384            
  Lines        22353    22353            
  Branches      3528     3528            
=========================================
  Hits          7296     7296            
- Misses       14940    15056   +116     
+ Partials       117        1   -116     

@ProtagNeptune
Copy link
Contributor Author

Oops...sorry for the commits spam? 😅

Copy link
Owner

@Bionus Bionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the UI file, but did you update the .ts files by hand? 😅

There's a CMake command for that, that'd be not only easier but it'd avoid having incorrect translations like now in Russian for example:

<source>Open log folder</source>
<translation>Открыть каталог настроек</translation>

The old one should be marked as missing and a new one created AFAIK. I'll run the command on your PR 👍

@Bionus Bionus self-requested a review June 25, 2024 22:24
@Bionus Bionus self-assigned this Jun 25, 2024
@ProtagNeptune
Copy link
Contributor Author

ProtagNeptune commented Jun 26, 2024

LGTM for the UI file, but did you update the .ts files by hand? 😅

Yeah, I changed those files before finding out about the codespace thing so I did it one by one...

There's a CMake command for that, that'd be not only easier but it'd avoid having incorrect translations like now in Russian for example:

<source>Open log folder</source>
<translation>Открыть каталог настроек</translation>

The old one should be marked as missing and a new one created AFAIK. I'll run the command on your PR 👍

Sorry about that. Should it be something like that now?

<source>Open log folder</source>
<translation type="unfinished"/>

@Bionus
Copy link
Owner

Bionus commented Jul 1, 2024

FWIW, the easiest way to update those files in a correct way is to build the translations (all projects) or General_translations (gui only) target. Then, Qt will automatically look for new translations and missing ones, and update the files accordingly. Just did it on your PR, in the end it didn't make much difference except for the missing "vanished" translations 😄

Copy link
Owner

@Bionus Bionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Bionus Bionus merged commit e5295e9 into Bionus:develop Jul 1, 2024
5 of 9 checks passed
@ProtagNeptune ProtagNeptune deleted the patch-1 branch July 2, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants