Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates some dependencies #268

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Updates some dependencies #268

merged 3 commits into from
Jun 28, 2021

Conversation

tylerconstance
Copy link
Contributor

The blockers present in @zemccartney's writeup in #267 are still present, though it looks like there's an open PR for that issue now on that project, so hopefully we'll be able to update webpack in another maintenance cycle or two.

Running npx npm-check-updates -m resulted in this list:

 babel-jest            26.x.x  →   27.x.x     
 copy-webpack-plugin   ^6.0.3  →   ^9.0.0     
 dotenv                ^8.2.0  →  ^10.0.0     
 html-webpack-plugin    4.x.x  →    5.x.x     
 jest                  26.x.x  →   27.x.x     
 webpack                4.x.x  →    5.x.x     
 history              ^4.10.1  →   ^5.0.0   

dotenv managed to get two major releases in about two weeks, but the only listed breaking change was dropping support for an older version of node that we already don't support in strangeluv.

jest was slightly trickier because it had a significant changelog for version 27. Our simple test didn't initially pass, but changing the testEnvironment to a newer version which supported getVmContext seemed to do the trick.

We were using jest-environment-jsdom-fifteen, and searching for the next logical iteration revealed that jest-environment-jsdom-sixteen was actually deprecated after being integrated into jest v26. Just changing that string from jest-environment-jsdom-fifteen to jest-environment-jsdom seemed to do the trick, though, and our test passes again.

Updating babel-jest to match, now we're left with the un-upgraded list we're familiar with:

 copy-webpack-plugin   ^6.0.3  →  ^9.0.0     
 html-webpack-plugin    4.x.x  →   5.x.x     
 webpack                4.x.x  →   5.x.x     
 history              ^4.10.1  →  ^5.0.0  

"version": "26.6.2",
"resolved": "https://registry.npmjs.org/@jest/console/-/console-26.6.2.tgz",
"integrity": "sha512-IY1R2i2aLsLr7Id3S6p2BA82GNWryt4oSvEXLAKc+L2zdi89dSkE8xC1C+0kpATG4JhBJREnQOH7/zmccM2B0g==",
"version": "27.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't actually expecting to see package-lock.json in this project since this is usually the starting point for most projects — should I remove this file in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good idea 👍

@jdonisvitch jdonisvitch merged commit 8243aae into strangeluv Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants