Remove "browser" version #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #18 Since the problem with uglify is fixed there is not reason to keep browser version which do not add any benefits. Actually it blocks us from distributing `esm` version which is widely used these days and supported by the most popular bundlers like webpack, rollup and parcel. Here's a few links facebook/fbjs#86 (comment) Both uglify and babel minify support evaulation and eliminating ```js (function () { function warning() {} var __DEV__ = 'production' !== 'production' if (__DEV__) { warning = function (msg) { console.log(msg) } } warning() } ()); ``` https://skalman.github.io/UglifyJS-online/ https://babeljs.io/repl#?babili=true&browsers=&build=&builtIns=false&code_lz=BQMwrgdgxgLglgewgAmASmQbwFDOeaeJZAdwEMAnCOCAc3SwF9tdkA3S5AfS4BEBRAGo9kAXmQByAA4UEAEzCxEECcgCEo8dNkKlSCSzxwQqHgOFcMOPHnJUatMfkh6UwALYBnWldY3kUEieCAA2AKYAdCEI9F4-fsjMeMysdtR06NiMqGhoANxAA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&lineWrap=false&presets=babili%2Cenv&prettier=false&targets=&version=6.26.0&envVersion=1.6.2
|
@BerkeleyTrue friendly ping. If you are busy are could help to maintain this project. |
|
@BerkeleyTrue Sorry for noise but I would like to get your feedback. |
|
@TrySound thanks for the pin. I say the first one a couple of days ago but I've been buried in a personal project. This is on my list. @zertosh I'm pretty sure you where the original committer for these files. I see you are still have the browser version of invariant in your package. I'd appreciate it if you could take a quick glance here. I don't remember the specifics of that issue. Thanks. |
|
Friendly ping @zertosh . Would be good to see your opinion. |
|
👍 |
Closed
|
@TrySound I will be review this pr later tonight. |
|
fixed in 521f5f5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #18
Since the problem with uglify is fixed there is not reason to keep
browser version which do not add any benefits. Actually it blocks us
from distributing
esmversion which is widely used these days andsupported by the most popular bundlers like webpack, rollup and parcel.
Here's a few links
facebook/fbjs#86 (comment)
Both uglify and babel minify support evaulation and eliminating
https://skalman.github.io/UglifyJS-online/
https://babeljs.io/repl#?babili=true&browsers=&build=&builtIns=false&code_lz=BQMwrgdgxgLglgewgAmASmQbwFDOeaeJZAdwEMAnCOCAc3SwF9tdkA3S5AfS4BEBRAGo9kAXmQByAA4UEAEzCxEECcgCEo8dNkKlSCSzxwQqHgOFcMOPHnJUatMfkh6UwALYBnWldY3kUEieCAA2AKYAdCEI9F4-fsjMeMysdtR06NiMqGhoANxAA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&lineWrap=false&presets=babili%2Cenv&prettier=false&targets=&version=6.26.0&envVersion=1.6.2