Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify class relationships #217

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Simplify class relationships #217

merged 6 commits into from
Oct 14, 2024

Conversation

rouson
Copy link
Contributor

@rouson rouson commented Oct 14, 2024

After the recent replacement of trainable_engine_t's polymorphic differentiable_activation_strategy component by a non-polymorphic activation_t component, there is no longer a compelling motivation for trainable_engine_t to be completely separate from inference_engine_t. This PR replaces trainable_engine_t with a new trainable_network_t that extends inference_engine_t and is defined in the same module as inference_engine_t to give it direct access to the parent inference_engine_t's components.

@rouson rouson merged commit e7794c5 into develop Oct 14, 2024
6 checks passed
@rouson rouson deleted the simplify-class-relationships branch October 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant