Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around ifx automatic-offloading bugs #145

Merged
merged 2 commits into from
May 8, 2024
Merged

Work around ifx automatic-offloading bugs #145

merged 2 commits into from
May 8, 2024

Conversation

rouson
Copy link
Contributor

@rouson rouson commented Apr 16, 2024 •
edited
Loading

This PR works around issues that arise when the following build command is used to tell the ifx compiler to automatically offload do concurrent constructs to a GPU:

fpm test --compiler ifx --flag "-coarray -coarray-num-images=1 -fopenmp-target-do-concurrent -qopenmp -fopenmp-targets=spir64"

The workarounds are

  1. further reduce iterations in trainable_engine_test_m so training converges with ifx without crashing
  2. convert do concurrent with array statements to do loops

@rouson rouson requested a review from ktras April 16, 2024 23:16
@rouson rouson changed the title test(trainable_engine): reduce iterations with ifx Work around ifx automatic-offloading bugs Apr 16, 2024
@rouson rouson marked this pull request as draft April 16, 2024 23:25
@ktras ktras marked this pull request as ready for review May 8, 2024 17:19
ktras
ktras approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ktras ktras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for fixing working around one ifx bug.

@ktras ktras merged commit 990e211 into main May 8, 2024
4 checks passed
@ktras ktras deleted the ifx-workaround branch May 8, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktras ktras ktras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rouson @ktras