Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(fpm.toml): increment dependency versions #131

Merged
merged 1 commit into from
Mar 15, 2024
Merged

build(fpm.toml): increment dependency versions #131

merged 1 commit into from
Mar 15, 2024

Conversation

rouson
Copy link
Contributor

@rouson rouson commented Mar 14, 2024

Update the fpm manifest to use the Assert 1.6.0 and Sourcery 4.6.0 releases that now support building those dependencies with the Cray Compiler Environment (CCE) 17.0.0 Fortran compiler.

@rouson
build(fpm.toml): increment dependency versions
8b21891 
Update the fpm manifest to use the Assert 1.6.0  and Sourcery 4.6.0
releases that now support building those dependencies with the
Cray Compiler Environment (CCE) 17.0.0 Fortran compiler.
federicavil

This comment was marked as duplicate.

Sign in to view

federicavil
federicavil approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@federicavil federicavil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ktras
ktras approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@ktras ktras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with ifx and can confirm that these version changes compile fine with ifx. Have opened issue #132 to add ifx and any other possible Fortran compilers to the CI so as to make this check automatic.

@ktras ktras merged commit 0ad6812 into main Mar 15, 2024
4 checks passed
@ktras ktras deleted the update-dependency-versions branch March 15, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicavil federicavil federicavil approved these changes

@ktras ktras ktras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rouson @ktras @federicavil