Release 1.15 #365
Merged
Release 1.15 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czech translation
German translation
Japanese translation
- Everytime new phase was set, plugin sent the first block of the phase 2 times. - CustomBlocks in fixedBlocks were causing issues where it was pushing the CustomBlock multiple times into queue. - Phase config was not refreshed when doing /isa reload. I tested it and I do not see any issues. Refactors: - Variable naming refactors, because having name `obPhase` for `phase` instance + name `phase` for the `ConfigurationSection` was not really understandable (I changed it to `phaseConfig`) Added features: - New `CustomBlock` for mobs in format: ``` - type: mob mob: ZOMBIE underlying-block: GRASS_BLOCK ``` It will spawn a mob on top of underlying block. I know that mob spawns are not exactly counted as "destroyed block", but in this case it is needed. It would not make sense setting it in fixedBlocks if not.
- New `Requirement - cooldown` (seconds) that blocks new phase until time elapses.
…obCustomBlock.java Co-authored-by: Huynh Tien <[email protected]>
Bug fixes & CustomBlock type for mob spawning
* Fixed: - `Requirement - cooldown` was not working properly Refactors: - Minor refactors to `BlockListener.process` method for better readability * Clarified that requirement value is in seconds * - Moved `setNewPhase` back to `CheckPhase` class - Fixed tests - Refactored test run args as they were weirdly formatted * Removed unused imports --------- Co-authored-by: tastybento <[email protected]>
The only time this might be null is after loading from the database, and is rare.
Put {} around the e.setCancelled(true) to make it clear that only this
statement is to be run.
* Translate uk.yml via GitLocalize * Translate uk.yml via GitLocalize * Translate uk.yml via GitLocalize --------- Co-authored-by: GIGABAIT <[email protected]> Co-authored-by: mt-gitlocalize <[email protected]> Co-authored-by: BONNe <[email protected]>
* Let ItemsAdder be a new OneBlockCustomBlock * fix conflict
* - Fixed `goToBlock` that was not working correctly after introducing `cooldown` requirement. * Removed debug print. Opsie..
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.