Fix backtrack error and add Windows EOL support to the annotate command #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaffe-fr
force-pushed
the
fix/windows-eol
branch
from
420591a to
85727fb
Compare
shaffe-fr
force-pushed
the
fix/windows-eol
branch
from
85727fb to
2a7f36f
Compare
|
Thanks, released with v6.2.2 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
This pull request addresses the issue of the backtrack limit being exhausted on big enum file and provides a solution by simplifying the regex. Additionally, support for Windows style EOL has been added.
The changes have been thoroughly tested and the changes have been recorded in the CHANGELOG.
I'm not sure how to update existing tests to include Windows compatibility.