Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getAttributeDescription() error #264

Merged

Conversation

PortableSteve
Copy link
Contributor

  • Added or updated tests
  • Added or updated the README.md
  • Detailed changes in the CHANGELOG.md unreleased section

Related Issue/Intent
Resolves #263

Changes
Calling MyEnum::getDescription($value) with an invalid value now returns an empty string, rather than throwing an error. This is in line with the behaviour in v4.

Breaking changes
N/A

@BenSampo BenSampo merged commit 808f1a8 into BenSampo:master Apr 8, 2022
@BenSampo
Copy link
Owner

BenSampo commented Apr 8, 2022

Thank you @PortableSteve 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getDescription() throws error if value does not exist in v5
2 participants