Narrow property type hints #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenSampo Would you like to review this, or can I just merge trivial changes like this? |
|
@spawnia Sorry, haven't had a chance to review yet. If you're happy with it then I am - please go ahead and merge. Same for any future non breaking changes. |
|
Thanks @BenSampo, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added or updated the README.mdRelated Issue/Intent
I noticed that static analysis in my project failed, due to using
$keyand$descriptionasstring.Changes
Narrows the property type hints of enum classes.
I also added PHPStan analysis for this project itself to ensure the changes I made are correct and fixed some static analysis errors.
Breaking changes
None, since we are not using strong types for the properties.