fix: $model->getChanges() triggered due to strict comparison
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atymic
commented
Oct 25, 2020
| @@ -495,6 +495,10 @@ public static function parseDatabase($value) | |||
| */ | |||
| public static function serializeDatabase($value) | |||
| { | |||
| if ($value instanceof self) { | |||
| return $value->value; | |||
There was a problem hiding this comment.
This is the meat of the change and falls back to $value just in case
atymic
commented
Oct 25, 2020
| use Illuminate\Contracts\Console\Kernel; | ||
| use Illuminate\Filesystem\Filesystem; | ||
|
|
||
| class ArtisanCommandsTest extends ApplicationTestCase | ||
| { | ||
| /** | ||
| * TODO remove once we cut support for Laravel < 5.7 |
atymic
commented
Oct 25, 2020
| @@ -72,4 +73,21 @@ public function test_model_with_trait_but_no_casts() | |||
| $model->foo = true; | |||
| $this->assertTrue($model->foo); | |||
| } | |||
|
|
|||
| public function test_get_changes_works_correctly() | |||
There was a problem hiding this comment.
Tried to repro the test case from #166
|
@BenSampo Please review this. Laravel's "dirty attribute" logic is currently broken because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
Resolves #166
Changes
Fixes
getChanges()being polluted by non changes. Laravel is using strict comparison under the hood, so comparing two different enum instances will return false. Comparing the underlying native types will return true.Breaking changes
None