Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHPStan level 3; various fixes #281

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

uuf6429
Copy link
Contributor

@uuf6429 uuf6429 commented Jan 31, 2025

No description provided.

@uuf6429 uuf6429 marked this pull request as ready for review January 31, 2025 21:57
@uuf6429 uuf6429 force-pushed the chore/phpstan-level-3 branch from 6969a49 to bc9da46 Compare February 1, 2025 16:01
Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @uuf6429 - just the discussion on the absolute path checks.

src/Behat/Gherkin/Loader/DirectoryLoader.php Outdated Show resolved Hide resolved
@uuf6429 uuf6429 requested a review from acoulton February 3, 2025 19:34
Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks :-)

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks @uuf6429

@carlos-granados carlos-granados merged commit e016902 into Behat:master Feb 5, 2025
8 checks passed
@uuf6429 uuf6429 deleted the chore/phpstan-level-3 branch February 6, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants