change: Deprecate Gherkin::VERSION constant and change file cache namespacing #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `tearDown` was only attempting to remove `*.feature.cache` in the configured path, however the FileCache actually writes files in a directory below that path. Therefore nothing was being deleted and the files from one test were still present for the next (and at the end of the run). Generate a unique directory for every test and use `symfony/filesystem` to ensure that the entire directory tree is properly cleaned up.
The previous test required internal knowledge of the directory and filenaming pattern used by the FileCache. Refactor to instead identify the file at runtime so that the test is not coupled to the implementation of the cache.
…amespaced The `Gherkin::VERSION` constant has not been updated for recent releases, and will not be part of our release process in the future. This constant was only being used internally to ensure that any pre-existing file caches are invalidated when a different version of the parser is installed. I have switched this to get a version from the composer runtime API, which should be at least as reliable as the previous hardcoded constant for this purpose.
acoulton
force-pushed
the
4.x-deprecate-version
branch
from
969444e to
3ea6101
Compare
carlos-granados
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.