Fixed the color handling for early exceptions #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the colors setting is taken into account even when an exception occurs during the config parsing. Fixes Behat#509
This allows these scenarios to pass on Windows where the autodetection in child process will not always disable colors automatically, given the environment variables are forwarded.
| @@ -189,4 +195,15 @@ protected function getCommandName(InputInterface $input) | |||
|
|
|||
| return $this->getName(); | |||
| } | |||
|
|
|||
| protected function configureIO(InputInterface $input, OutputInterface $output) | |||
There was a problem hiding this comment.
Application is final. There's no point in adding protected methods in :) Make it private?
There was a problem hiding this comment.
this is overwriting a method of the Symfony application to extend it (hence the call to the parent method)
everzet
added a commit
that referenced
this pull request
Apr 26, 2014
Fixed the color handling for early exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #509
The second commit adds some missing
--no-colorsin the testsuite in places asserting the output.