Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logical operator typing #1000 #1021

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix logical operator typing #1000 #1021

merged 1 commit into from
Sep 19, 2024

Conversation

janas-adam
Copy link
Contributor

@janas-adam janas-adam commented Sep 5, 2024 •
edited
Loading

adjusted typings in logical operators for avoiding typing error

see #1000

@janas-adam janas-adam mentioned this pull request Sep 5, 2024
Open
@adeelsohailahmed adeelsohailahmed requested a review from a team September 11, 2024 23:24
adeelsohailahmed
adeelsohailahmed approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this.

Riverfount
Riverfount approved these changes Sep 18, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@07pepa 07pepa merged commit e10af51 into BeanieODM:main Sep 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07pepa 07pepa 07pepa approved these changes

@Riverfount Riverfount Riverfount approved these changes

@adeelsohailahmed adeelsohailahmed adeelsohailahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janas-adam @07pepa @Riverfount @adeelsohailahmed