Fix disk quota for iOS #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1337mus
approved these changes
Feb 13, 2023
The default disk quota for CocoaLumberjack is 20MB. This can cause the logging to be smaller than expected. To avoid this additional constraint, it is disabled in this commit.
|
Nice catch ! Sorry for the long wait. |
|
Landed in v0.5.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default disk quota for CocoaLumberjack is 20MB.
This can cause the logging to be smaller than expected. For example, when the logging is set to 10 files with 4MB each, only 5 files are created on iOS.
To avoid this additional constraint, the disk quota is disabled in this change.