-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arbitrary environment #69
Labels
Comments
Yes, you're right. It requires a small change so I'll work on it as soon as possible |
Merged
This change was included by #73 so I'll close this issue. If someone thinks it's not working properly or could be improved, feel free to comment here and I'll open the issue again. |
Hi, thanks for that, I did not have the time to test bare metal deployments
yet but the change looks OK!
TY for implementing this :)
…On Mon, Feb 12, 2024 at 3:13 PM Matheus Baldissara ***@***.***> wrote:
This change was included by #73
<#73> so I'll close
this issue. If someone thinks it's not working properly or could be
improved, feel free to comment here and I'll open the issue again.
—
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAV5D5RD2GDT5I7JHGCDE5DYTIPR5AVCNFSM6AAAAABCYH4G5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYG42TONRUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While I understand target audience is supposed to run via Docker there's no technical reason why the directory where data is stored and port the app is listening on are not sourced from
process.env
.This would allow bare metal hosting at no cost to app's maintainability.
The text was updated successfully, but these errors were encountered: