BAH-3411 | Fixed. Address issues and email issue #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohan-13
requested changes
Jan 3, 2024
| @@ -94,7 +94,7 @@ def _get_address_details(self, address): | |||
|
|
|||
| @api.model | |||
| def _find_country(self, address): | |||
| return self.env['res.company'].search([], limit=1).partner_id.country_id | |||
| return self.env['res.country'].sudo().search([('name', '=', address.get('country'))], limit=1) | |||
There was a problem hiding this comment.
@hari1119 Please do not use sudo, it is removed now and we are passing sessionid
mohan-13
approved these changes
Jan 4, 2024
hari1119
pushed a commit
that referenced
this pull request
Jan 10, 2024
* [Hari] | BAH-3411 | Fixed. Address issues and email issue has been fixed. * [Hari] | BAH-3411-1 | Refactor. Sudo access was removed
rahu1ramesh
pushed a commit
that referenced
this pull request
Feb 9, 2024
* [Hari] | BAH-3440 | Fixed. order line qty logic changed. * BAH-3411 | Fixed. Address issues and email issue (#41) * [Hari] | BAH-3411 | Fixed. Address issues and email issue has been fixed. * [Hari] | BAH-3411-1 | Refactor. Sudo access was removed * BAH-3444 | Fix. AttributeError was fixed (#40) * [Hari] | BAH-3444 | Fix. AttributeError was fixed * [Hari] | BAH-3444 | Fixed. bahmni_api_feed module removed in the depends. * [Hari] | BAH-3440 | Refactor. log message added & UOM logic was changed * [BAH-3440] | Refactor. UOM relasted mapping changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira --> BAH-3411, BAH-3329,BAH-3369
In this PR below issues are resolved.