Fix duplicate error messages issue #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
duplicate-errors
branch
from
360f95d to
e5ad07c
Compare
|
Awesome work tracking this down and making a fix! I saw that mocha has a Regardless, even though this is a workaround as you said, I'm fine with merging this since it's not practical to force everyone to use that mocha option (if it even works). Looks like you've fixed the tests. Good to go on your end? |
| @@ -31,7 +31,7 @@ function test(p, opts) { | |||
| ) { | |||
| throw new Error( | |||
| chalk.red('Code did not pass lint rules') + | |||
| formatter(report.results) | |||
| formatter(report.results).replace(process.cwd() + '/', '') | |||
There was a problem hiding this comment.
Actually, do you think you could add a small comment to explain why the replace is needed? I can see this causing some head-scratching in the future.
This is a workaround for mochajs/mocha#2126 but since relative paths are usually much nicer to look at it also has its own advantages
Turbo87
force-pushed
the
duplicate-errors
branch
from
e5ad07c to
03472e5
Compare
yes, I think this should solve the issue. might be good if you could verify that everything else still works properly though. |
IanVS
added a commit
that referenced
this pull request
Feb 25, 2016
Fix duplicate error messages issue
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #29