Make now configurable so time can freeze during backburner run loop
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow us to use fake timers, such as `sinon.useFakeTimers`, to check the state of the app during the run loop. For example: if a popup is supposed to be triggered in X ms from now and it will show to the user during Y ms, then this will allow us to use fake timers to pause between X and Y and check the state of the Ember app at that exact time.
rwjblue
approved these changes
Sep 20, 2017
|
This brings |
alias-mac
added a commit
to alias-mac/backburner.js
that referenced
this pull request
Sep 21, 2017
This allow us to use fake timers, such as `sinon.useFakeTimers`, to check the state of the app during the run loop. For example: if a popup is supposed to be triggered in X ms from now and it will show to the user during Y ms, then this will allow us to use fake timers to pause between X and Y and check the state of the Ember app at that exact time. This is related with BackburnerJS#263, BackburnerJS#179 and BackburnerJS#166. If someone needs to have the backburner clock separate from the global stubbed clock (as explained in BackburnerJS#179), then `_platform.now` config should be used to pass the native `Date.now` function.
I think we have it the way it is by design. For example, the autorun flush should not be interuptable. |
|
Ya, I think I’m not grok’ing something here. Can we chat about this in higher bandwidth so I can make sure I understand? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow us to use fake timers, such as
sinon.useFakeTimers, tocheck the state of the app during the run loop.
For example: if a popup is supposed to be triggered in X ms from now and
it will show to the user during Y ms, then this will allow us to use
fake timers to pause between X and Y and check the state of the Ember
app at that exact time.